From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755605AbdBGWxE (ORCPT ); Tue, 7 Feb 2017 17:53:04 -0500 Received: from smtprelay0061.hostedemail.com ([216.40.44.61]:38102 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752108AbdBGWxC (ORCPT ); Tue, 7 Feb 2017 17:53:02 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3867:3868:3870:4321:5007:8603:10004:10400:10848:11026:11658:11914:12048:12296:12740:12760:12895:13069:13138:13231:13255:13311:13357:13439:14659:14721:21080:21212:21433:30029:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:16,LUA_SUMMARY:none X-HE-Tag: hall13_8e85aee1c5f58 X-Filterd-Recvd-Size: 1806 Message-ID: <1486507978.27834.3.camel@perches.com> Subject: Re: [PATCH 13/18] HID-debug: Combine 11 seq_printf() calls into one call in hid_dump_field() From: Joe Perches To: SF Markus Elfring , linux-input@vger.kernel.org, Benjamin Tissoires , Bruno =?ISO-8859-1?Q?Pr=E9mont?= , Jiri Kosina Cc: LKML , kernel-janitors@vger.kernel.org Date: Tue, 07 Feb 2017 14:52:58 -0800 In-Reply-To: <99abe158-ba41-99eb-95e1-e9aed7bafb53@users.sourceforge.net> References: <99abe158-ba41-99eb-95e1-e9aed7bafb53@users.sourceforge.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-02-07 at 20:56 +0100, SF Markus Elfring wrote: > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c [] > @@ -614,19 +614,18 @@ void hid_dump_field(struct hid_field *field, int n, struct seq_file *f) { > tab(n, f); seq_printf(f, "Report Size(%u)\n", field->report_size); > tab(n, f); seq_printf(f, "Report Count(%u)\n", field->report_count); > tab(n, f); seq_printf(f, "Report Offset(%u)\n", field->report_offset); > - > - tab(n, f); seq_printf(f, "Flags( "); > + tab(n, f); Consider converting tab(n, f) to seq_indent(f, n) making seq_indent a global function or maybe using a new name like seq_spaces, and converting the existing uses in net/ipv4/fib_trie.c appropriately.