From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049AbdBHKmq (ORCPT ); Wed, 8 Feb 2017 05:42:46 -0500 Received: from smtprelay0090.hostedemail.com ([216.40.44.90]:60931 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753739AbdBHKmE (ORCPT ); Wed, 8 Feb 2017 05:42:04 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2898:3138:3139:3140:3141:3142:3622:3867:4321:5007:6642:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12048:12296:12438:12740:12760:12895:13069:13311:13357:13439:13972:14659:14721:21080:30012:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: knee37_4bbf04a33a432 X-Filterd-Recvd-Size: 1488 Message-ID: <1486550518.27834.13.camel@perches.com> Subject: Re: [PATCH v2 06/16] net: stmmac: fix some code style problem From: Joe Perches To: Corentin Labbe , peppe.cavallaro@st.com, alexandre.torgue@st.com, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Date: Wed, 08 Feb 2017 02:41:58 -0800 In-Reply-To: <20170208083121.27949-7-clabbe.montjoie@gmail.com> References: <20170208083121.27949-1-clabbe.montjoie@gmail.com> <20170208083121.27949-7-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-08 at 09:31 +0100, Corentin Labbe wrote: > Checkpatch complains about some code style problem on stmmac_mdio.c. > This patch fix them. [] > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c [] > @@ -258,6 +258,7 @@ int stmmac_mdio_register(struct net_device *ndev) > found = 0; > for (addr = 0; addr < PHY_MAX_ADDR; addr++) { > struct phy_device *phydev = mdiobus_get_phy(new_bus, addr); > + > if (phydev) { > int act = 0; > char irq_num[4]; Maybe use if (!phydev) continue; to reduce indentation