From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751523AbdBHT64 (ORCPT ); Wed, 8 Feb 2017 14:58:56 -0500 Received: from smtprelay0177.hostedemail.com ([216.40.44.177]:50764 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751111AbdBHT6W (ORCPT ); Wed, 8 Feb 2017 14:58:22 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2196:2197:2199:2200:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3653:3865:3866:3867:3868:3870:3871:3872:3874:4250:4321:4385:5007:6120:6691:6742:7903:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12555:12740:12895:13439:13894:14181:14659:14721:21080:21221:21433:21451:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: hands18_58f378675c114 X-Filterd-Recvd-Size: 3993 Message-ID: <1486583609.27834.21.camel@perches.com> Subject: Re: [RFC 19/19] checkpatch: warn for use of old PCI pool API From: Joe Perches To: Peter Senna Tschudin , Romain Perier Cc: Dan Williams , Doug Ledford , Sean Hefty , Hal Rosenstock , jeffrey.t.kirsher@intel.com, "David S. Miller" , stas.yakovlev@gmail.com, "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , Greg Kroah-Hartman , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Senna Tschudin Date: Wed, 08 Feb 2017 11:53:29 -0800 In-Reply-To: <20170208185550.GS16878@collabora.com> References: <20170208163457.28853-1-romain.perier@collabora.com> <20170208163457.28853-20-romain.perier@collabora.com> <20170208185550.GS16878@collabora.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-08 at 19:55 +0100, Peter Senna Tschudin wrote: > On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote: > > pci_pool_*() functions should be replaced by the corresponding functions > > in the DMA pool API. This adds support to check for use of these pci > > functions and display a warning when it is the case. > > Don't know if relevant, but did not catch the struct. Other than that > works fine. > > > > > Signed-off-by: Romain Perier > > --- > > scripts/checkpatch.pl | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index 8e96af5..026920e 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -6058,6 +6058,11 @@ sub process { > > WARN("USE_DEVICE_INITCALL", > > "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr); > > } > > +# check for old PCI api pci_pool_*(), use dma_pool_*() instead > > + if ($line =~ /\bpci_pool_.+\(/) { > > + WARN("USE_PCI_POOL", > > + "please use the dma pool api or more appropriate function instead of the old pci pool api\n" . $herecurr); > > + } > > > > # check for various structs that are normally const (ops, kgdb, device_tree) > > if ($line !~ /\bconst\b/ && > > -- > > 2.9.3 > > Did this patch get to lkml? Perhaps this would be more complete:  scripts/checkpatch.pl | 9 +++++++++  1 file changed, 9 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 8e96af53611c..600f81cc1ec1 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6059,6 +6059,15 @@ sub process {        "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);   }   +# check for old PCI api pci_pool_*(), use dma_pool_*() instead + if ($line =~ /\bpci_pool(?:_(?:create|destroy|alloc|zalloc|free)|)\b/) { + if (WARN("USE_DMA_POOL", +  "please use the dma pool api or more appropriate function instead of the old pci pool api\n" . $herecurr) && +     $fix) { + while ($fixed[$fixlinenr] =~ s/\bpci_pool(_(?:create|destroy|alloc|zalloc|free)|)\b/dma_pool$1/) {} + } + } +  # check for various structs that are normally const (ops, kgdb, device_tree)   if ($line !~ /\bconst\b/ &&       $line =~ /\bstruct\s+($const_structs)\b/) {