From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752207AbdBILfe (ORCPT ); Thu, 9 Feb 2017 06:35:34 -0500 Received: from mga05.intel.com ([192.55.52.43]:31051 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021AbdBILfd (ORCPT ); Thu, 9 Feb 2017 06:35:33 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,349,1484035200"; d="scan'208";a="1124198869" Message-ID: <1486639986.2133.425.camel@linux.intel.com> Subject: Re: [PATCH] platform/x86: intel_pmc_ipc: read s0ix residency API From: Andy Shevchenko To: Rajneesh Bhardwaj , Shanth Murthy Cc: platform-driver-x86@vger.kernel.org, dvhart@infradead.org, qipeng.zha@intel.com, linux-kernel@vger.kernel.org Date: Thu, 09 Feb 2017 13:33:06 +0200 In-Reply-To: <20170209064717.GA24247@rajaneesh-OptiPlex-9010> References: <1486386591-5739-1-git-send-email-shanth.murthy@intel.com> <20170209064717.GA24247@rajaneesh-OptiPlex-9010> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-02-09 at 12:17 +0530, Rajneesh Bhardwaj wrote: > On Mon, Feb 06, 2017 at 05:09:51AM -0800, Shanth Murthy wrote: > > Signed-off-by: Rajneesh Bhardwaj   > > +static int intel_pmc_s0ix_counter_read(u64 *data) > > +{ > > + return -EINVAL; > > +} > > + > > How about making it static inline and return -ENOSYS instead of > -EINVAL? I'm not sure what's going on. Your SoB is in this patch and now it feels like you are reviewing this patch. What should I do? -- Andy Shevchenko Intel Finland Oy