* [PATCH -next] sched/x86: Remove duplicated include from itmt.c
@ 2017-02-09 15:15 Wei Yongjun
2017-02-09 17:52 ` Tim Chen
2017-02-10 8:16 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2017-02-09 15:15 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Tim Chen
Cc: Wei Yongjun, x86, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Remove duplicated include.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
arch/x86/kernel/itmt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kernel/itmt.c b/arch/x86/kernel/itmt.c
index f73f475..b5ccc9b 100644
--- a/arch/x86/kernel/itmt.c
+++ b/arch/x86/kernel/itmt.c
@@ -20,7 +20,6 @@
* frequency under ITMT.
*/
-#include <linux/sched.h>
#include <linux/cpumask.h>
#include <linux/cpuset.h>
#include <linux/mutex.h>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] sched/x86: Remove duplicated include from itmt.c
2017-02-09 15:15 [PATCH -next] sched/x86: Remove duplicated include from itmt.c Wei Yongjun
@ 2017-02-09 17:52 ` Tim Chen
2017-02-10 8:16 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Tim Chen @ 2017-02-09 17:52 UTC (permalink / raw)
To: Wei Yongjun, Thomas Gleixner, Ingo Molnar, H. Peter Anvin
Cc: Wei Yongjun, x86, linux-kernel
On Thu, 2017-02-09 at 15:15 +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Remove duplicated include.
Acked-by: Tim Chen <tim.c.chen@linux.intel.com>
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> arch/x86/kernel/itmt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/itmt.c b/arch/x86/kernel/itmt.c
> index f73f475..b5ccc9b 100644
> --- a/arch/x86/kernel/itmt.c
> +++ b/arch/x86/kernel/itmt.c
> @@ -20,7 +20,6 @@
> * frequency under ITMT.
> */
>
> -#include <linux/sched.h>
> #include <linux/cpumask.h>
> #include <linux/cpuset.h>
> #include <linux/mutex.h>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] sched/x86: Remove duplicated include from itmt.c
2017-02-09 15:15 [PATCH -next] sched/x86: Remove duplicated include from itmt.c Wei Yongjun
2017-02-09 17:52 ` Tim Chen
@ 2017-02-10 8:16 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2017-02-10 8:16 UTC (permalink / raw)
To: Wei Yongjun
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Tim Chen,
Wei Yongjun, x86, linux-kernel
* Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Remove duplicated include.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> arch/x86/kernel/itmt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/itmt.c b/arch/x86/kernel/itmt.c
> index f73f475..b5ccc9b 100644
> --- a/arch/x86/kernel/itmt.c
> +++ b/arch/x86/kernel/itmt.c
> @@ -20,7 +20,6 @@
> * frequency under ITMT.
> */
>
> -#include <linux/sched.h>
> #include <linux/cpumask.h>
> #include <linux/cpuset.h>
> #include <linux/mutex.h>
Firstly, we generally use 'larger' headers first, i.e. sched.h, mm.h, etc.
Secondly, this:
#include <linux/sched.h>
#include <linux/cpumask.h>
#include <linux/cpuset.h>
#include <linux/mutex.h>
#include <linux/sysctl.h>
#include <linux/nodemask.h>
... can probably be further reduced, because for example sched.h already includes
some of these headers.
I.e. instead of a mindless single liner that helps no-one, try to improve the code
for real...
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-10 8:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-09 15:15 [PATCH -next] sched/x86: Remove duplicated include from itmt.c Wei Yongjun
2017-02-09 17:52 ` Tim Chen
2017-02-10 8:16 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).