From: "De Marchi, Lucas" <lucas.demarchi@intel.com>
To: "mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"jarkko.nikula@linux.intel.com" <jarkko.nikula@linux.intel.com>,
"Nehal-Bakulchandra.Shah@amd.com"
<Nehal-Bakulchandra.Shah@amd.com>
Cc: "wsa@the-dreams.de" <wsa@the-dreams.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"Shyam-sundar.S-k@amd.com" <Shyam-sundar.S-k@amd.com>
Subject: Re: [PATCH] i2c: designware: Fix regression when dynamic TAR update is disabled
Date: Thu, 9 Feb 2017 21:34:10 +0000 [thread overview]
Message-ID: <1486676048.14478.4.camel@intel.com> (raw)
In-Reply-To: <1486670858.2133.436.camel@linux.intel.com>
On Thu, 2017-02-09 at 22:07 +0200, Andy Shevchenko wrote:
> On Fri, 2017-02-10 at 01:20 +0530, Shah Nehal-Bakulchandra wrote:
> > The following commit causes a regression when dynamic TAR update is
> > disabled:
> >
> > commit 63d0f0a6952a1a02bc4f116b7da7c7887e46efa3 ("i2c:
> > designware:
> > detect when dynamic tar update is possible")
>
> Please, leave just 12 characters, it still enough.
>
> > In such case, the DW_IC_CON_10BITADDR_MASTER is R/W, and is changed
> > by the logic that's trying to detect dynamic TAR update.The original
> > value of DW_IC_CON_10BITADDR_MASTER bit should be restored.
You are right, thanks for the fix. This may also explains why
0317e6c (i2c: designware: do not disable adapter after transfer) caused problems
and ended up being reverted. Could you try that on your hardware?
The dynamic tar update detection was only done as preparation work to allow not
disabling the adapter, which is reverted. We may also just revert this commit
instead of fixing the logic.
thanks
Lucas De Marchi
next prev parent reply other threads:[~2017-02-09 21:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 19:50 [PATCH] i2c: designware: Fix regression when dynamic TAR update is disabled Shah Nehal-Bakulchandra
2017-02-09 20:07 ` Andy Shevchenko
2017-02-09 21:34 ` De Marchi, Lucas [this message]
2017-02-10 6:38 ` Suravee Suthikulpanit
2017-02-10 10:48 ` Jarkko Nikula
2017-02-13 4:15 ` Shah, Nehal-bakulchandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486676048.14478.4.camel@intel.com \
--to=lucas.demarchi@intel.com \
--cc=Nehal-Bakulchandra.Shah@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox