From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753483AbdBJU7l (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Feb 2017 15:59:41 -0500
Received: from gate.crashing.org ([63.228.1.57]:46082 "EHLO gate.crashing.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752468AbdBJU7k (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Feb 2017 15:59:40 -0500
Message-ID: <1486760361.3401.48.camel@kernel.crashing.org>
Subject: Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Cyril Bur <cyrilbur@gmail.com>, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
Cc: mikey@neuling.org, joel@jms.id.au, openbmc@lists.ozlabs.org
Date: Sat, 11 Feb 2017 07:59:21 +1100
In-Reply-To: <20170207234247.19425-1-cyrilbur@gmail.com>
References: <20170207234247.19425-1-cyrilbur@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.4 (3.22.4-2.fc25) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-02-08 at 10:42 +1100, Cyril Bur wrote:
> +struct aspeed_lpc_ctrl_mapping {
> +       __u8    window_type;
> +       __u8    window_id;
> +       __u16   flags;
> +       __u32   addr;
> +       __u32   offset;
> +       __u32   size;
> +};
> +

Please document the fields

Cheers,
Ben.