From: "Tobin C. Harding" <me@tobin.cc>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, "Tobin C. Harding" <me@tobin.cc>
Subject: [PATCH v2 0/2] x86/purgatory: Fix sparse warnings
Date: Mon, 13 Feb 2017 08:07:30 +1100 [thread overview]
Message-ID: <1486933652-28245-1-git-send-email-me@tobin.cc> (raw)
Sparse emits multiple warnings of type 'symbol was not declared'.
Separate fixes into two patches. In first patch add static keyword
to functions and variables which have file scope only.
In the second patch add a header file with the function declaration.
Include the header file in the C source file defining the function
in order to fix the sparse warning. Include the header file in ASM
file containing the call site thereby adding documentation of usage.
Tobin C. Harding (2):
x86/purgatory: Fix sparse warning, symbol not declared
x86/purgatory: Fix sparse warning, symbol not declared
arch/x86/purgatory/purgatory.c | 11 ++++++-----
arch/x86/purgatory/purgatory.h | 7 +++++++
arch/x86/purgatory/setup-x86_64.S | 3 ++-
3 files changed, 15 insertions(+), 6 deletions(-)
create mode 100644 arch/x86/purgatory/purgatory.h
--
2.7.4
next reply other threads:[~2017-02-12 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 21:07 Tobin C. Harding [this message]
2017-02-12 21:07 ` [PATCH v2 1/2] x86/purgatory: Fix sparse warning, symbol not declared Tobin C. Harding
2017-02-12 21:07 ` [PATCH v2 2/2] " Tobin C. Harding
2017-02-12 22:08 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486933652-28245-1-git-send-email-me@tobin.cc \
--to=me@tobin.cc \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox