* [PATCH] Staging: media: bcm2048: Fixed coding style issue.
@ 2017-02-12 21:45 Ran Algawi
2017-02-13 11:26 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Ran Algawi @ 2017-02-12 21:45 UTC (permalink / raw)
To: gregkh; +Cc: linux-media, devel, linux-kernel
Fixed a coding style issue, where an octal value was needed insted of decimal.
Signed-off-by: Ran Algawi <ran.algawi@gmail.com>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 37bd439..d605c41 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -300,7 +300,7 @@ struct bcm2048_device {
};
static int radio_nr = -1; /* radio device minor (-1 ==> auto assign) */
-module_param(radio_nr, int, 0);
+module_param(radio_nr, int, 0000);
MODULE_PARM_DESC(radio_nr,
"Minor number for radio device (-1 ==> auto assign)");
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Staging: media: bcm2048: Fixed coding style issue.
2017-02-12 21:45 [PATCH] Staging: media: bcm2048: Fixed coding style issue Ran Algawi
@ 2017-02-13 11:26 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2017-02-13 11:26 UTC (permalink / raw)
To: Ran Algawi, gregkh; +Cc: linux-media, devel, linux-kernel
On 02/12/2017 10:45 PM, Ran Algawi wrote:
> Fixed a coding style issue, where an octal value was needed insted of decimal.
>
> Signed-off-by: Ran Algawi <ran.algawi@gmail.com>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 37bd439..d605c41 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -300,7 +300,7 @@ struct bcm2048_device {
> };
>
> static int radio_nr = -1; /* radio device minor (-1 ==> auto assign) */
> -module_param(radio_nr, int, 0);
> +module_param(radio_nr, int, 0000);
Let's make this 0444, just like most other media drivers with a radio_nr param.
In fact, I propose that you make this patch more useful by looking at the output of:
git grep module_param drivers/media/|grep '\(video_nr\)\|\(radio_nr\)\|\(vbi_nr\)'
and change all to 0444. I see a mix of 0000, 0444 and 0644 being used, but 0444
is really the only sensible one.
Hans
> MODULE_PARM_DESC(radio_nr,
> "Minor number for radio device (-1 ==> auto assign)");
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-13 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-12 21:45 [PATCH] Staging: media: bcm2048: Fixed coding style issue Ran Algawi
2017-02-13 11:26 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox