From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752962AbdBMTHA (ORCPT ); Mon, 13 Feb 2017 14:07:00 -0500 Received: from smtprelay0229.hostedemail.com ([216.40.44.229]:44019 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752165AbdBMTG6 (ORCPT ); Mon, 13 Feb 2017 14:06:58 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:69:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2689:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:4321:5007:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12296:12438:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21212:21451:30012:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: chair67_74fe95763a359 X-Filterd-Recvd-Size: 1762 Message-ID: <1487012802.6214.3.camel@perches.com> Subject: Re: [PATCH v4 net-next 5/8] sunvnet: straighten up message event handling logic From: Joe Perches To: Shannon Nelson , netdev@vger.kernel.org, davem@davemloft.net Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 13 Feb 2017 11:06:42 -0800 In-Reply-To: <1487012224-403399-6-git-send-email-shannon.nelson@oracle.com> References: <1487012224-403399-1-git-send-email-shannon.nelson@oracle.com> <1487012224-403399-6-git-send-email-shannon.nelson@oracle.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-02-13 at 10:57 -0800, Shannon Nelson wrote: > The use of gotos for handling the incoming events made this code > harder to read and support than it should be. This patch straightens > out and clears up the logic. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/sun/sunvnet_common.c | 94 ++++++++++++++--------------- > 1 files changed, 45 insertions(+), 49 deletions(-) > > diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c [] > @@ -738,41 +738,37 @@ static int vnet_event_napi(struct vnet_port *port, int budget) [] > + /* we don't expect any other bits */ > + BUG_ON(port->rx_event & ~(LDC_EVENT_DATA_READY | > + LDC_EVENT_RESET | > + LDC_EVENT_UP)); Is it really necessary to use BUG_ON here?