From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753180AbdBMVON convert rfc822-to-8bit (ORCPT ); Mon, 13 Feb 2017 16:14:13 -0500 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:8099 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbdBMVOL (ORCPT ); Mon, 13 Feb 2017 16:14:11 -0500 X-IronPort-AV: E=Sophos;i="5.35,157,1483977600"; d="scan'208";a="80676655" X-AuditID: ac1c2133-e2b7d9800001a7e2-54-58a2215df8d0 From: Bart Van Assche To: "tj@kernel.org" , "paolo.valente@linaro.org" , "axboe@kernel.dk" CC: "ulf.hansson@linaro.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "broonie@kernel.org" , "linus.walleij@linaro.org" Subject: Re: [PATCH BUGFIX] block: make elevator_get robust against cross blk/blk-mq choice Thread-Topic: [PATCH BUGFIX] block: make elevator_get robust against cross blk/blk-mq choice Thread-Index: AQHShj30IE9eWtd6wkKC44gXnPdMBg== Date: Mon, 13 Feb 2017 21:12:59 +0000 Message-ID: <1487020366.2719.5.camel@sandisk.com> References: <20170213210107.4848-1-paolo.valente@linaro.org> <20170213210107.4848-2-paolo.valente@linaro.org> In-Reply-To: <20170213210107.4848-2-paolo.valente@linaro.org> Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.181.8.64] Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsWyRobxn26s4qIIgy+nrC1W3+1ns5j68Amb xZQ/y5ks9t7Stri8aw6bxas/e5ksfi0/ymhxfG24A4fH5bOlHptWdbJ53Lm2h83j8ya5AJYo LpuU1JzMstQifbsErowNG36zFSzgqNj5RKSB8T5bFyMnh4SAicS3ab8Yuxi5OIQEljBJtH/b xgzhXGKU2HLwK1gVm4CRxOwJe1hAEiICjYwSs9tvsoM4zAKzmSQub3jKBFIlLBArsWbBBjBb RCBOYuPCaawQtp7E3nfzGUFsFgFVibevV7KA2LwChhJXz/5nB7GFBAokPqzZAGZzCthK/D28 GmgOBwejgKxEy2tukDCzgLjErSfzmSDOFpBYsuc8M4QtKvHy8T9WkHIJAXmJ66ftIMr1JG5M ncIGYVtJfGxqZYKwtSWWLXzNDHGBoMTJmU9YJjCKzUKyYRaS9llI2mchaZ+FpH0BI+sqRrHi xOTi3PTUAkMTveLEvJTM4my95PzcTYzgCFU03sH4b4P7IUYBDkYlHt4JBxZGCLEmlhVX5h5i lOBgVhLhnfobKMSbklhZlVqUH19UmpNafIhRmoNFSZw3ZvbUCCGB9MSS1OzU1ILUIpgsEwen VAOj60JNxZMfV7j82Hn0m+rDgrA1wWXVf5l3pTBN+XvfSuXOu7iM0s079GeunO5/xHraGt+q lgU1zLxKPEql8t5zHdherle7wr7qapVO4fSZRedOpTs07g7x8Ql6Vxm0xXt6k0KEQ/3dfZ/5 bfpi/Dxc52SHbFq8INTPR1MooqD1/sPdJrNKf+YpsRRnJBpqMRcVJwIA27na7cwCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-02-13 at 22:01 +0100, Paolo Valente wrote: > -static struct elevator_type *elevator_get(const char *name, bool try_loading) > +static struct elevator_type *elevator_get(const char *name, bool try_loading, > + bool mq_ops) Please choose a better name for that argument, e.q. "mq". To me the name "mq_ops" means "a pointer to a data structure with operation function pointers". > + if (e && (e->uses_mq != mq_ops)) { > + pr_err("ERROR: attempted to choose %s %s I/O scheduler in blk%s", > + name, e->uses_mq ? "blk-mq" : "legacy", mq_ops ? "-mq" : ""); > + e = NULL; > + } How about changing the above into: +       if (e && e->uses_mq != mq) { +               pr_err("ERROR: attempt to configure %s as I/O scheduler for a %s queue\n", +                      name, mq ? "blk-mq" : "legacy"); +               e = NULL; +       } Thanks, Bart.