From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753222AbdBNOgg (ORCPT ); Tue, 14 Feb 2017 09:36:36 -0500 Received: from mga07.intel.com ([134.134.136.100]:30099 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753128AbdBNOgb (ORCPT ); Tue, 14 Feb 2017 09:36:31 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,161,1484035200"; d="scan'208";a="65022099" Message-ID: <1487082982.21310.0.camel@linux.intel.com> Subject: Re: [PATCH v2] tools/power/x86: Debug utility for intel_pstate driver From: Srinivas Pandruvada To: "Rafael J. Wysocki" Cc: Doug Smythies , len.brown@intel.com, dsmythies@telus.net, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Date: Tue, 14 Feb 2017 06:36:22 -0800 In-Reply-To: <4440842.OSZWjPAjve@aspire.rjw.lan> References: <1487027947-14306-1-git-send-email-dsmythies@telus.net> <1487045940.3025.5.camel@linux.intel.com> <4440842.OSZWjPAjve@aspire.rjw.lan> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.4 (3.22.4-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-02-14 at 12:15 +0100, Rafael J. Wysocki wrote: > On Monday, February 13, 2017 08:19:00 PM Srinivas Pandruvada wrote: > > On Mon, 2017-02-13 at 15:19 -0800, Doug Smythies wrote: > > > This utility can be used to debug and tune the performance of the > > > intel_pstate driver. > > > This utility can be used in two ways: > > > - If there is Linux trace file with pstate_sample events enabled, > > > then > > > this utility can parse the trace file and generate performance > > > plots. > > > - If user has not specified a trace file as input via command > > > line > > > parameters, then this utility enables and collects trace data for > > > a > > > user > > > specified interval and generates performance plots. > > > > > > Signed-off-by: Doug Smythies > > > > I am fine with this version. But since Rafael may have already > > prepared > > for pull request, so it is up to him. > > I can replace your version with this one if that's OK. Please do that. Thanks, Srinivas