From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755193AbdBNUXc (ORCPT ); Tue, 14 Feb 2017 15:23:32 -0500 Received: from smtprelay0209.hostedemail.com ([216.40.44.209]:39667 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754941AbdBNUXX (ORCPT ); Tue, 14 Feb 2017 15:23:23 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3867:3868:3871:3873:4321:5007:7903:8957:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12296:12438:12555:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: root80_74838d47d4b5b X-Filterd-Recvd-Size: 1981 Message-ID: <1487103799.6214.27.camel@perches.com> Subject: Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues From: Joe Perches To: simran singhal , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 14 Feb 2017 12:23:19 -0800 In-Reply-To: <20170214201432.GA4150@singhal-Inspiron-5558> References: <20170214201432.GA4150@singhal-Inspiron-5558> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-15 at 01:44 +0530, simran singhal wrote: [] > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c [] > @@ -150,14 +150,15 @@ static inline char *rtl819x_translate_scan(struct ieee80211_device *ieee, > PHT_CAPABILITY_ELE ht_cap = NULL; > bool is40M = false, isShortGI = false; > u8 max_mcs = 0; > + > if (!memcmp(network->bssht.bdHTCapBuf, EWC11NHTCap, 4)) > ht_cap = (PHT_CAPABILITY_ELE)&network->bssht.bdHTCapBuf[4]; > else > ht_cap = (PHT_CAPABILITY_ELE)&network->bssht.bdHTCapBuf[0]; > - is40M = (ht_cap->ChlWidth)?1:0; > - isShortGI = (ht_cap->ChlWidth)? > - ((ht_cap->ShortGI40Mhz)?1:0): > - ((ht_cap->ShortGI20Mhz)?1:0); > + is40M = (ht_cap->ChlWidth) ? 1 : 0; > + isShortGI = (ht_cap->ChlWidth) ? > + ((ht_cap->ShortGI40Mhz) ? 1 : 0) : > + ((ht_cap->ShortGI20Mhz) ? 1 : 0); You have a brain, checkpatch is brainless. Please remember to do more than just shut-up checkpatch. This could be simplified by removing parentheses and ternaries to isShortGI = ht_cap->Ch1Width ? ht_cap->ShortGI40Mhz : ht_cap->ShortGI20Mhz;