From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755318AbdBNUcQ (ORCPT ); Tue, 14 Feb 2017 15:32:16 -0500 Received: from smtprelay0016.hostedemail.com ([216.40.44.16]:40870 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754328AbdBNUcI (ORCPT ); Tue, 14 Feb 2017 15:32:08 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:6119:6691:10004:10400:10848:11026:11232:11657:11658:11914:12043:12294:12438:12555:12740:12760:12895:13069:13095:13311:13357:13439:14181:14659:14721:21080:21433:30054:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: pan16_2f6b990ba0154 X-Filterd-Recvd-Size: 1751 Message-ID: <1487104324.6214.29.camel@perches.com> Subject: Re: [PATCH v2 5/9] staging: rtl8192u: Use min_t instead of min From: Joe Perches To: simran singhal , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 14 Feb 2017 12:32:04 -0800 In-Reply-To: <20170214201333.GA2764@singhal-Inspiron-5558> References: <20170214201333.GA2764@singhal-Inspiron-5558> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-15 at 01:43 +0530, simran singhal wrote: > Use min_t instead of min function in ieee80211/ieee80211_wx.c > fixed warning: > WARNING: min() should probably be min_t(u8, network->ssid_len, 32) [] > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c [] > @@ -80,7 +80,7 @@ static inline char *rtl819x_translate_scan(struct ieee80211_device *ieee, > iwe.u.data.length = sizeof(""); > start = iwe_stream_add_point(info, start, stop, &iwe, ""); > } else { > - iwe.u.data.length = min(network->ssid_len, (u8)32); > + iwe.u.data.length = min_t(u8, network->ssid_len, 32); Umm, no. A checkpatch message that says "probably", is not a reason to do what it says. It's _maybe_ something that could be investigated. ssid_len is size_t and u.data.length is u16. Why should it be truncated to a u8? It'd be getter to remove the u8 cast altogether.