Re: [PATCH 1/2] fpga: Add flag to indicate bitstream needs decrypting

Moritz Fischer
2017-02-15T18:02:47Z

On Wed, Feb 15, 2017 at 5:30 PM, Alan Tull <atull@kernel.org> wrote:
> On Wed, Feb 15, 2017 at 9:03 AM, Michal Simek <michal.simek@xilinx.com> wrote:

>>> #define FPGA_MGR_PARTIAL_RECONFIG BIT(0)
>>> #define FPGA_MGR_EXTERNAL_CONFIG BIT(1)
>>> +#define FPGA_MGR_DECRYPT_BITSTREAM BIT(2)
>>>
>>> /**
>>> * struct fpga_image_info - information specific to a FPGA image
>>>
>>
>> Isn't it better to state that bitstream is encrypted
>> instead of saying that bitstream requires decryption?
>
> Such as FPGA_MGR_ENCRYPTED_BITSTREAM ?

Yeah, can do. This was basically a 'redo' of my earlier 'capability' based
patchset. There it made more sense to have a 'can decrypt' capability.

> Also please consider adding a DT property such that the FPGA region
> code will set this flag similar to how the DTO sets up other FPGA
> image info.

Yeah, had that on my list. Can add that to v3.

Cheers,

Moritz