Re: [PATCH 1/2] fpga: Add flag to indicate bitstream needs decrypting

Michal Simek
2017-02-15T15:04:02Z

On 15.2.2017 01:31, mdf@kernel.org wrote:
> From: Moritz Fischer <moritz.fischer@ettus.com>
>
> Add a flag that is passed to the write_init() callback, indicating
> that the bitstream is encrypted.
>
> The low-level driver will deal with the flag, or return an error,
> if encrypted bitstreams are not supported.
>
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> Cc: Alan Tull <atull@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-fpga@vger.kernel.org
> ---
> include/linux/fpga/fpga-mgr.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
> index 57beb5d..1355d8a 100644
> --- a/include/linux/fpga/fpga-mgr.h
> +++ b/include/linux/fpga/fpga-mgr.h
> @@ -70,6 +70,7 @@ enum fpga_mgr_states {
> */
> #define FPGA_MGR_PARTIAL_RECONFIG BIT(0)
> #define FPGA_MGR_EXTERNAL_CONFIG BIT(1)
> +#define FPGA_MGR_DECRYPT_BITSTREAM BIT(2)
>
> /**
> * struct fpga_image_info - information specific to a FPGA image
>

Isn't it better to state that bitstream is encrypted
instead of saying that bitstream requires decryption?

Your second patch is saying add support for encrypted bitstreams.

M