Re: [PATCH 1/2] fpga: Add flag to indicate bitstream needs decrypting

Michal Simek
2017-02-15T18:07:54Z

On 15.2.2017 19:02, Moritz Fischer wrote:
> On Wed, Feb 15, 2017 at 5:30 PM, Alan Tull <atull@kernel.org> wrote:
>> On Wed, Feb 15, 2017 at 9:03 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>
>>>> #define FPGA_MGR_PARTIAL_RECONFIG BIT(0)
>>>> #define FPGA_MGR_EXTERNAL_CONFIG BIT(1)
>>>> +#define FPGA_MGR_DECRYPT_BITSTREAM BIT(2)
>>>>
>>>> /**
>>>> * struct fpga_image_info - information specific to a FPGA image
>>>>
>>>
>>> Isn't it better to state that bitstream is encrypted
>>> instead of saying that bitstream requires decryption?
>>
>> Such as FPGA_MGR_ENCRYPTED_BITSTREAM ?
>
> Yeah, can do. This was basically a 'redo' of my earlier 'capability' based
> patchset. There it made more sense to have a 'can decrypt' capability.

Just keep in your mind that there are use cases where you also need to
pass keys.

Thanks,
Michal