From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790AbdBOD1z (ORCPT ); Tue, 14 Feb 2017 22:27:55 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35425 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbdBOD1x (ORCPT ); Tue, 14 Feb 2017 22:27:53 -0500 X-ME-Sender: X-Sasl-enc: JHFPFJQEVw8VD4Ea5Rw0xzpKYNQv/wBbb6sS2GzGzCY4 1487129267 From: "Tobin C. Harding" To: Thomas Petazzoni , noralf@tronnes.org Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, "Tobin C. Harding" Subject: [PATCH v2 2/3] staging: fbtft: Replace magic number with constant Date: Wed, 15 Feb 2017 14:27:24 +1100 Message-Id: <1487129245-24970-3-git-send-email-me@tobin.cc> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1487129245-24970-1-git-send-email-me@tobin.cc> References: <1487129245-24970-1-git-send-email-me@tobin.cc> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Current call to strncmp() uses a magic number. There is a compile time constant defined for this buffer, included and used already at other sites in the file. Remove magic number. Replace with pre-existing compile time constant. Signed-off-by: Tobin C. Harding --- drivers/staging/fbtft/fbtft_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index 7b7223b..5fbdd37 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft_device.c @@ -1489,7 +1489,7 @@ static int __init fbtft_device_init(void) } for (i = 0; i < ARRAY_SIZE(displays); i++) { - if (strncmp(name, displays[i].name, 32) == 0) { + if (strncmp(name, displays[i].name, SPI_NAME_SIZE) == 0) { if (displays[i].spi) { spi = displays[i].spi; spi->chip_select = cs; -- 2.7.4