From: Joe Perches <joe@perches.com>
To: SIMRAN SINGHAL <singhalsimran0@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues
Date: Tue, 14 Feb 2017 19:31:20 -0800 [thread overview]
Message-ID: <1487129480.6214.39.camel@perches.com> (raw)
In-Reply-To: <CALrZqyNoZkhtNR60MJMBfceir4EUVzG_jNoxf-p6QkwZtj9_5A@mail.gmail.com>
On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote:
> Yes, I totally agree with joe.
>
> But as there is no coding style issue in this patch.
Style is more than just checkpatch conformity.
> So, do I have to resend the complete patch series again?
I'm not applying any of these so that's entirely up
to Greg.
Perhaps he might apply the first 5 patches and reject
this one, maybe he might apply all the patches.
In any case, do strive to develop some reasonable
semblance of style and do more than just checkpatch
suggested patches and find and fix some actual defect
somewhere.
next prev parent reply other threads:[~2017-02-15 3:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 20:14 [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues simran singhal
2017-02-14 20:23 ` Joe Perches
2017-02-15 3:22 ` SIMRAN SINGHAL
2017-02-15 3:31 ` Joe Perches [this message]
2017-02-15 8:18 ` SIMRAN SINGHAL
2017-02-15 9:23 ` Joe Perches
2017-02-16 18:32 ` Greg KH
2017-02-16 19:08 ` SIMRAN SINGHAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487129480.6214.39.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox