From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751741AbdBODiU (ORCPT ); Tue, 14 Feb 2017 22:38:20 -0500 Received: from smtprelay0106.hostedemail.com ([216.40.44.106]:35136 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751503AbdBODiT (ORCPT ); Tue, 14 Feb 2017 22:38:19 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3866:3867:3870:3873:4321:5007:6119:8957:10004:10400:10848:11026:11232:11658:11914:12043:12296:12663:12740:12760:12895:13069:13255:13311:13357:13439:14180:14181:14659:14721:21060:21080:21324:21451:30029:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: self73_82881558b4e2b X-Filterd-Recvd-Size: 2072 Message-ID: <1487129895.6214.43.camel@perches.com> Subject: Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name From: Joe Perches To: Arushi Singhal Cc: arnaud.patard@rtp-net.org, Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 14 Feb 2017 19:38:15 -0800 In-Reply-To: References: <20170214203300.GA10308@arushi-HP-Pavilion-Notebook> <1487105038.6214.30.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-15 at 09:01 +0530, Arushi Singhal wrote: > Hi Joe > Sorry but I am unable to find the identifier of "unsigned long" .Shall you > please help me in how to find the identifier. > Thanks > Arushi Singhal $ git grep -w XGIRegInit drivers/staging/xgifb/XGI_main_26.c:void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr) > On Wed, Feb 15, 2017 at 2:13 AM, Joe Perches wrote: > > > On Wed, 2017-02-15 at 02:03 +0530, Arushi Singhal wrote: > > > function definition argument 'struct vb_device_info *' should also have > > > an identifier name. > > > > [] > > > diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_ > > > > init.h > > [] > > > @@ -1,6 +1,6 @@ > > > #ifndef _VBINIT_ > > > #define _VBINIT_ > > > unsigned char XGIInitNew(struct pci_dev *pdev); > > > -void XGIRegInit(struct vb_device_info *, unsigned long); > > > +void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long); > > > > Why do one argument but not the other? > > > >