Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

Greg KH
2017-02-16T18:32:21Z

On Wed, Feb 15, 2017 at 01:48:13PM +0530, SIMRAN SINGHAL wrote:
> On Wed, Feb 15, 2017 at 9:01 AM, Joe Perches <joe@perches.com> wrote:
> > On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote:
> >> Yes, I totally agree with joe.
> >>
> >> But as there is no coding style issue in this patch.
> >
> > Style is more than just checkpatch conformity.
> >
> >> So, do I have to resend the complete patch series again?
> >
> > I'm not applying any of these so that's entirely up
> > to Greg.
> >
> > Perhaps he might apply the first 5 patches and reject
> > this one, maybe he might apply all the patches.
> >
> > In any case, do strive to develop some reasonable
> > semblance of style and do more than just checkpatch
> > suggested patches and find and fix some actual defect
> > somewhere.
>
> Joe, I am new to Linux kernel and just have basic knowledge of
> C and C++.

As Joe said, the kernel is _not_ the project to learn C with. Please
get some more experience with userspace programs in C first, before
working on the kernel. It will be much easier for you.

thanks,

greg k-h