From: Alan Cox <alan@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Gabriel C <nix.or.die@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Peter Anvin <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mike Galbraith <efault@gmx.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ruslan Ruslichenko <rruslich@cisco.com>,
stable@vger.kernel.org
Subject: Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional loading
Date: Wed, 15 Feb 2017 12:17:47 +0000 [thread overview]
Message-ID: <1487161067.3636.1.camel@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1702151157110.3562@nanos>
> > > I'm seriously grumpy about this engineering trainwreck, which has
> > > seven
> > > SOBs from Intel developers for 50 lines of code. And none of them
> > > figured
> > > out that this is broken. Impressive fail!
It was discussed at the time, documented at the time. Unfortunately the
people who did the emulator didn't feel the urge to provide a way to
detect the platform was Goldfish.
Historically it also used its own custom device discovery scheme. Given
the limited use of older versions of Goldfish it might well make sense
to remove support for the older emulator versions.
Alan
next prev parent reply other threads:[~2017-02-15 12:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 10:11 [patch 0/2] goldfish: Prevent the trainwreck from doing harm Thomas Gleixner
2017-02-15 10:11 ` [patch 1/2] x86/platform/goldfish: Prevent unconditional loading Thomas Gleixner
2017-02-15 10:53 ` Peter Zijlstra
2017-02-15 10:57 ` Thomas Gleixner
2017-02-15 12:17 ` Alan Cox [this message]
2017-02-15 14:52 ` Thomas Gleixner
2017-02-15 10:11 ` [patch 2/2] goldfish: Sanitize the broken interrupt handler Thomas Gleixner
2017-02-15 15:49 ` [patch 0/2] goldfish: Prevent the trainwreck from doing harm Linus Torvalds
2017-02-15 16:52 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487161067.3636.1.camel@linux.intel.com \
--to=alan@linux.intel.com \
--cc=bp@alien8.de \
--cc=efault@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nix.or.die@gmail.com \
--cc=peterz@infradead.org \
--cc=rruslich@cisco.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox