From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752089AbdBOMRy (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Feb 2017 07:17:54 -0500
Received: from mga05.intel.com ([192.55.52.43]:1328 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751813AbdBOMRx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Feb 2017 07:17:53 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,165,1484035200"; 
   d="scan'208";a="65436862"
Message-ID: <1487161067.3636.1.camel@linux.intel.com>
Subject: Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional loading
From: Alan Cox <alan@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Gabriel C <nix.or.die@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Peter Anvin <hpa@zytor.com>,
        Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Mike Galbraith <efault@gmx.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ruslan Ruslichenko <rruslich@cisco.com>, stable@vger.kernel.org
Date: Wed, 15 Feb 2017 12:17:47 +0000
In-Reply-To: <alpine.DEB.2.20.1702151157110.3562@nanos>
References: <20170215101149.937286619@linutronix.de>
         <20170215102145.074836404@linutronix.de>
         <20170215105301.GB6557@twins.programming.kicks-ass.net>
         <alpine.DEB.2.20.1702151157110.3562@nanos>
Organization: Intel Corporation
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > > I'm seriously grumpy about this engineering trainwreck, which has
> > > seven
> > > SOBs from Intel developers for 50 lines of code. And none of them
> > > figured
> > > out that this is broken. Impressive fail!

It was discussed at the time, documented at the time. Unfortunately the
people who did the emulator didn't feel the urge to provide a way to
detect the platform was Goldfish.

Historically it also used its own custom device discovery scheme. Given
the limited use of older versions of Goldfish it might well make sense
to remove support for the older emulator versions.

Alan