From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755972AbdBPAT4 (ORCPT ); Wed, 15 Feb 2017 19:19:56 -0500 Received: from smtprelay0045.hostedemail.com ([216.40.44.45]:48620 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754211AbdBPATx (ORCPT ); Wed, 15 Feb 2017 19:19:53 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3867:3868:3871:3874:4321:5007:6691:7904:7974:10004:10400:10848:11232:11658:11914:12663:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21433:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: spade08_38dc77adf3955 X-Filterd-Recvd-Size: 2240 Message-ID: <1487204389.6214.68.camel@perches.com> Subject: Re: [PATCH] checkpatch: add warning on %pk instead of %pK usage From: Joe Perches To: "Roberts, William C" , Andrew Morton Cc: "linux-kernel@vger.kernel.org" , "apw@canonical.com" , "kernel-hardening@lists.openwall.com" Date: Wed, 15 Feb 2017 16:19:49 -0800 In-Reply-To: <476DC76E7D1DF2438D32BFADF679FC5623064D3F@ORSMSX103.amr.corp.intel.com> References: <1486755469-21573-1-git-send-email-william.c.roberts@intel.com> <1486757549.2192.20.camel@perches.com> <476DC76E7D1DF2438D32BFADF679FC562305C559@ORSMSX103.amr.corp.intel.com> <476DC76E7D1DF2438D32BFADF679FC562305C5BA@ORSMSX103.amr.corp.intel.com> <1486766996.2192.30.camel@perches.com> <476DC76E7D1DF2438D32BFADF679FC562305DC7B@ORSMSX103.amr.corp.intel.com> <1486783428.2192.44.camel@perches.com> <476DC76E7D1DF2438D32BFADF679FC562305F372@ORSMSX103.amr.corp.intel.com> <1487016251.6214.6.camel@perches.com> <476DC76E7D1DF2438D32BFADF679FC562305F62F@ORSMSX103.amr.corp.intel.com> <1487024441.6214.12.camel@perches.com> <476DC76E7D1DF2438D32BFADF679FC5623064D3F@ORSMSX103.amr.corp.intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-15 at 23:49 +0000, Roberts, William C wrote: > > > > This means _all_ the $stat checks aren't being done on patches that add just a > > single multi-line statement. > > > > Andrew? Any thoughts on how to enable $stat appropriately for patch contexts > > with a single multi-line statement? > > I'm for merging your patch as is, and then take up the fact that $stat is not working correctly > as a separate change, does that seem reasonable? Sure, Andrew Morton is the typical upstream path for checkpatch. (cc'd) Andy Whitcroft? Any chance to look at this?