From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754361AbdBPApQ (ORCPT ); Wed, 15 Feb 2017 19:45:16 -0500 Received: from smtprelay0044.hostedemail.com ([216.40.44.44]:40949 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752357AbdBPApP (ORCPT ); Wed, 15 Feb 2017 19:45:15 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:966:968:973:988:989:1042:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3165:3352:3622:3865:3867:3868:3870:3873:4321:4385:5007:6119:7903:10004:10400:10848:11026:11232:11657:11658:11914:12043:12217:12296:12438:12740:12760:12895:13069:13255:13311:13357:13439:13972:14659:14721:21080:21451:30007:30029:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: star16_84d894cde493a X-Filterd-Recvd-Size: 2649 Message-ID: <1487205911.6214.71.camel@perches.com> Subject: Re: [PATCH v10 1/9] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug From: Joe Perches To: Suravee Suthikulpanit , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Cc: bp@alien8.de, peterz@infradead.org, joro@8bytes.org, mingo@redhat.com Date: Wed, 15 Feb 2017 16:45:11 -0800 In-Reply-To: <1487192185-31272-2-git-send-email-Suravee.Suthikulpanit@amd.com> References: <1487192185-31272-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1487192185-31272-2-git-send-email-Suravee.Suthikulpanit@amd.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-15 at 14:56 -0600, Suravee Suthikulpanit wrote: > Declare pr_fmt for perf/amd_iommu and remove unnecessary pr_debug. [] > diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c [] > @@ -11,6 +11,8 @@ > * published by the Free Software Foundation. > */ > > +#define pr_fmt(fmt) "perf/amd_iommu: " fmt > + > #include > #include > #include [] > @@ -444,24 +440,24 @@ static __init int _init_perf_amd_iommu( > > raw_spin_lock_init(&perf_iommu->lock); > > - /* Init format attributes */ > perf_iommu->format_group = &amd_iommu_format_group; > > /* Init cpumask attributes to only core 0 */ > cpumask_set_cpu(0, &iommu_cpumask); > perf_iommu->cpumask_group = &amd_iommu_cpumask_group; > > - /* Init events attributes */ > - if (_init_events_attrs(perf_iommu) != 0) > - pr_err("perf: amd_iommu: Only support raw events.\n"); > + ret = _init_events_attrs(perf_iommu); > + if (ret) { > + pr_err("Error initializing AMD IOMMU perf events.\n"); > + return ret; > + } > > - /* Init null attributes */ > perf_iommu->null_group = NULL; > perf_iommu->pmu.attr_groups = perf_iommu->attr_groups; > > ret = perf_pmu_register(&perf_iommu->pmu, name, -1); > if (ret) { > - pr_err("perf: amd_iommu: Failed to initialized.\n"); > + pr_err("Error initializing AMD IOMMU perf counters.\n"); > amd_iommu_pc_exit(); > } else { > pr_info("perf: amd_iommu: Detected. (%d banks, %d counters/bank)\n", You should remove the now unnecessary internal prefixes in the other pr_ uses like the pr_info above.