From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754330AbdBPK3Q (ORCPT ); Thu, 16 Feb 2017 05:29:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:42853 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753868AbdBPK3O (ORCPT ); Thu, 16 Feb 2017 05:29:14 -0500 Message-ID: <1487240929.22685.19.camel@suse.com> Subject: Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code From: Oliver Neukum To: "Gustavo A. R. Silva" , gregkh@linuxfoundation.org, thomas@winischhofer.net Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Thu, 16 Feb 2017 11:28:49 +0100 In-Reply-To: <20170208040134.GA4460@embeddedgus> References: <20170208040134.GA4460@embeddedgus> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: > The condition modex % 16 cannot be true when modex value is equal to > 640 > The condition du & 0xff cannot be true when du value is equal to > 0x1400 >  Sorry for speaking up so late, but this is not a good idea. We lose the knowledge how to do this correctly, if we want to change the resolution. Regards Oliver