From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934866AbdBQSuZ (ORCPT ); Fri, 17 Feb 2017 13:50:25 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44044 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934708AbdBQSuV (ORCPT ); Fri, 17 Feb 2017 13:50:21 -0500 Subject: Re: [PATCH] tpm: Fix expected number of response bytes of TPM1.2 PCR Extend From: Mimi Zohar To: Jarkko Sakkinen Cc: James Morris , Stefan Berger , tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 17 Feb 2017 13:48:38 -0500 In-Reply-To: <20170217184546.ik2vv5bleahqhkwv@intel.com> References: <1487177783-15687-1-git-send-email-stefanb@linux.vnet.ibm.com> <20170215180903.3simazptqnlhbqi6@intel.com> <1487335598.15611.9.camel@linux.vnet.ibm.com> <20170217184546.ik2vv5bleahqhkwv@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17021718-0004-0000-0000-000001E20AE5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17021718-0005-0000-0000-000009AFA73B Message-Id: <1487357318.15611.68.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-17_16:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702170174 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-02-17 at 20:45 +0200, Jarkko Sakkinen wrote: > On Fri, Feb 17, 2017 at 07:46:38AM -0500, Mimi Zohar wrote: > > Hi James, > > > > On Wed, 2017-02-15 at 20:09 +0200, Jarkko Sakkinen wrote: > > > On Wed, Feb 15, 2017 at 11:56:23AM -0500, Stefan Berger wrote: > > > > The TPM1.2 PCR Extend operation only returns 20 bytes in the body, > > > > which is the size of the PCR state. > > > > > > > > This fixes a problem where IMA gets errors with every PCR Extend. > > > > > > > > Fixes: c659af78eb7b ("tpm: Check size of response before accessing data") > > > > Signed-off-by: Stefan Berger > > > > Acked-by: Mimi Zohar > > > > > > Reviewed-by: Jarkko Sakkinen > > > > This patch needs to be included with the rest of the patches being > > upstreamed in the next open window. Should Jarkko or I send you a pull > > request for it? > I'm sending a pull request after the weekend. It will contain > only a few small scoped fixes so wouldn't it be easiest if I > just include this to the pack? As long as it makes it into the James' pull request to Linus, that's fine. Mimi