From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934921AbdBQSui (ORCPT <rfc822;w@1wt.eu>);
        Fri, 17 Feb 2017 13:50:38 -0500
Received: from mail-pg0-f66.google.com ([74.125.83.66]:33968 "EHLO
        mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934756AbdBQSuV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Feb 2017 13:50:21 -0500
Message-ID: <1487357402.13283.1.camel@debian.org>
Subject: Re: [PATCH v3] Add sysfs interface for touchpad state
From: Ritesh Raj Sarraf <rrs@debian.org>
Reply-To: rrs@debian.org
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
        Ike Panhc <ike.pan@canonical.com>, Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date: Sat, 18 Feb 2017 00:20:02 +0530
In-Reply-To: <CAHp75Vd8oqnJLRP4HLsTD_SUThwvRNegektN+-bbeT5L8h-NTQ@mail.gmail.com>
References: <20170217144815.11791-1-rrs@debian.org>
         <CAHp75Vd8oqnJLRP4HLsTD_SUThwvRNegektN+-bbeT5L8h-NTQ@mail.gmail.com>
Organization: Debian
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.5-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Fri, 2017-02-17 at 18:12 +0200, Andy Shevchenko wrote:
> > +static ssize_t touchpad_store(struct device *dev,
> > +                                struct device_attribute *attr,
> > +                                const char *buf, size_t count)
> > +{
> > +       struct ideapad_private *priv = dev_get_drvdata(dev);
> > +       int ret, state;
> > +
> > +       ret = kstrtoint(buf, 0, &state);
> > +       if (ret)
> > +               return ret;
> 
> If it's intended to be boolean, better to use kstrtobool()

Thanks. Revised patch built, tested locally, and sent (git send-email).


- -- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQCVDstmIVAB/Yn02pjpYo/LhdWkFAlinRdoACgkQpjpYo/Lh
dWljCRAAqAqvbXABNFnoObBrQ4e4nULupH/R2FuAOU+tgKJUv6Fks85TuPvoNLwb
OYMP7HoXXKf1ME4lIILEhrl6UCvlOzN4lUbxdFaUhg/NvvduHc9n5v+hFDask/BC
dA+Vt4r8KI8FH6O5O/JqxkFm0UZSVA41K15fTsX/5JunH7f+SOKPQIjMAk3/3MBm
puVtxDUTHjx0yOTpzIv0xzIrVtwAeFtfINDG/M+e5wKuurCyZ+ARvRb0melRHGXH
N4PlAAZ2BvgLqHjZqU+EqkER1wiAPkpZw0VSavT9Efw+FMy/yKoogdRLImRNR8Sh
MwAuj+U4xL572n53x09w9UBbAGAbP4O4O/1DUl2zL6MXFtHboCs+AkPP9UYaUXYG
rhi3GSPHCDk0iQuXrwMmjyDw3Ta1RFJs4aBAuRdJOiifH0nOTsA5SmX4i4Mep+9k
QuMSEIHTNQpflAuGe0/4ku+QEQDm0L7IXxzqK7Ra+P9XdqOxa5iYyrbmPxqgL0xA
+DjT/92ZvHI5IFBBk/c5ZSCaRmSchaHiHWPG3z7qcP770jKqKAeMVeyxMAo8q/h7
J0E7w5p+kFn/71+3E4TvM1pC13mHwspAqheoIfYObPS1nU3XVIUpJ9A/rLLcvXY5
920LxV0Yz+Gs1GcgVlItOSSUhPeh11atzV3Y4UAnMuvh7RWWzDc=
=6Bli
-----END PGP SIGNATURE-----