From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964826AbdBQWu7 (ORCPT ); Fri, 17 Feb 2017 17:50:59 -0500 Received: from smtprelay0166.hostedemail.com ([216.40.44.166]:35078 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964787AbdBQWu6 (ORCPT ); Fri, 17 Feb 2017 17:50:58 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:3873:4321:5007:10004:10400:10848:11026:11232:11658:11914:12043:12438:12740:12760:12895:13069:13161:13229:13255:13311:13357:13439:14659:14721:21080:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: look82_7bda5aea8ba3d X-Filterd-Recvd-Size: 1665 Message-ID: <1487371848.2198.6.camel@perches.com> Subject: Re: [PATCH] Staging: ks7010: ks_*: Braces should be used on all arms of these statements From: Joe Perches To: Shiva Kerdel , gregkh@linuxfoundation.org Cc: wsa+renesas@sang-engineering.com, p.hoefflin@posteo.de, karniksayli1995@gmail.com, sabitha.george@gmail.com, georgiana.chelu93@gmail.com, goudapatilk@gmail.com, mihaela.muraru21@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Fri, 17 Feb 2017 14:50:48 -0800 In-Reply-To: <20170217214154.2792-1-shiva@exdev.nl> References: <20170217214154.2792-1-shiva@exdev.nl> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-02-17 at 22:41 +0100, Shiva Kerdel wrote: > Braces should be used on all arms of these statements (CHECK).. [] > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c [] > @@ -2148,8 +2148,9 @@ void hostif_sme_mode_setup(struct ks_wlan_private *priv) > else > rate_octet[i] = > priv->reg.rate_set.body[i]; > - } else > + } else { > break; > + } Generally, any time you see a form like this, the test should be reversed for/while/do { if (foo) { [bar...] } else { break; } should be: for/while/do { if (!foo) break; [bar...] }