From: Joe Perches <joe@perches.com>
To: Nathan Howard <adanhawthorn@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>,
Michael Zoran <mzoran@crowfest.net>,
devel@driverdev.osuosl.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue
Date: Fri, 17 Feb 2017 15:04:16 -0800 [thread overview]
Message-ID: <1487372656.2198.7.camel@perches.com> (raw)
In-Reply-To: <1487362603-15967-4-git-send-email-adanhawthorn@gmail.com>
On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote:
> Fix checkpatch.pl warning of the form "WARNING: Use of volatile is
> usually wrong: see Documentation/process/volatile-considered-harmful.rst."
Why are you sure the volatile use is not necessary?
> Signed-off-by: Nathan Howard <adanhawthorn@gmail.com>
> ---
> drivers/staging/bcm2835-audio/bcm2835.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835-audio/bcm2835.h
> index 2f9d1c9..08f7ad6 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835.h
> +++ b/drivers/staging/bcm2835-audio/bcm2835.h
> @@ -125,8 +125,8 @@ struct bcm2835_alsa_stream {
> struct semaphore buffers_update_sem;
> struct semaphore control_sem;
> spinlock_t lock;
> - volatile unsigned int control;
> - volatile unsigned int status;
> + unsigned int control;
> + unsigned int status;
>
> int open;
> int running;
next prev parent reply other threads:[~2017-02-17 23:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 20:16 [PATCH 1/5] staging: bcm2835-audio: bcm2835.h: fix block comment warning Nathan Howard
2017-02-17 20:16 ` [PATCH 2/5] staging: bcm2835-audio: bcm2835.h: fix printk coding style issue Nathan Howard
2017-02-17 20:16 ` [PATCH 3/5] staging: bcm2835-audio: bcm2835.h: fix macro " Nathan Howard
2017-02-17 20:16 ` [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile " Nathan Howard
2017-02-17 23:04 ` Joe Perches [this message]
2017-02-18 0:41 ` Adan Hawthorn
2017-02-17 20:16 ` [PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length " Nathan Howard
2017-02-18 1:17 ` Joe Perches
2017-02-18 1:32 ` Adan Hawthorn
2017-02-18 1:38 ` Joe Perches
2017-02-18 2:08 ` Adan Hawthorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487372656.2198.7.camel@perches.com \
--to=joe@perches.com \
--cc=adanhawthorn@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mzoran@crowfest.net \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox