From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964861AbdBQXFc (ORCPT ); Fri, 17 Feb 2017 18:05:32 -0500 Received: from smtprelay0160.hostedemail.com ([216.40.44.160]:32829 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964779AbdBQXFb (ORCPT ); Fri, 17 Feb 2017 18:05:31 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3871:3873:4321:5007:6119:6742:7514:10004:10400:10848:11026:11232:11658:11914:12043:12555:12740:12760:12895:13069:13255:13311:13357:13439:14096:14097:14181:14659:14721:21080:21451:30046:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: jail52_6069711daf04e X-Filterd-Recvd-Size: 2280 Message-ID: <1487372656.2198.7.camel@perches.com> Subject: Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue From: Joe Perches To: Nathan Howard Cc: Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Stephen Warren , Lee Jones , Eric Anholt , Michael Zoran , devel@driverdev.osuosl.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 17 Feb 2017 15:04:16 -0800 In-Reply-To: <1487362603-15967-4-git-send-email-adanhawthorn@gmail.com> References: <1487362603-15967-1-git-send-email-adanhawthorn@gmail.com> <1487362603-15967-4-git-send-email-adanhawthorn@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote: > Fix checkpatch.pl warning of the form "WARNING: Use of volatile is > usually wrong: see Documentation/process/volatile-considered-harmful.rst." Why are you sure the volatile use is not necessary? > Signed-off-by: Nathan Howard > --- > drivers/staging/bcm2835-audio/bcm2835.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835-audio/bcm2835.h > index 2f9d1c9..08f7ad6 100644 > --- a/drivers/staging/bcm2835-audio/bcm2835.h > +++ b/drivers/staging/bcm2835-audio/bcm2835.h > @@ -125,8 +125,8 @@ struct bcm2835_alsa_stream { > struct semaphore buffers_update_sem; > struct semaphore control_sem; > spinlock_t lock; > - volatile unsigned int control; > - volatile unsigned int status; > + unsigned int control; > + unsigned int status; > > int open; > int running;