From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752765AbdBRBSH (ORCPT ); Fri, 17 Feb 2017 20:18:07 -0500 Received: from smtprelay0148.hostedemail.com ([216.40.44.148]:44573 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752338AbdBRBSD (ORCPT ); Fri, 17 Feb 2017 20:18:03 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3873:3874:4250:4321:5007:6742:10004:10400:10848:11026:11232:11658:11914:12043:12438:12740:12760:12895:13069:13161:13229:13255:13311:13357:13439:14093:14096:14097:14181:14659:14721:21080:21324:30030:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: grass53_62b67a227ba2f X-Filterd-Recvd-Size: 2463 Message-ID: <1487380676.2198.11.camel@perches.com> Subject: Re: [PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length coding style issue From: Joe Perches To: Nathan Howard Cc: Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Stephen Warren , Lee Jones , Eric Anholt , Michael Zoran , devel@driverdev.osuosl.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 17 Feb 2017 17:17:56 -0800 In-Reply-To: <1487362603-15967-5-git-send-email-adanhawthorn@gmail.com> References: <1487362603-15967-1-git-send-email-adanhawthorn@gmail.com> <1487362603-15967-5-git-send-email-adanhawthorn@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote: > Fix checkpatch.pl warning of the form "WARNING: line over 80 characters." [] > diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835-audio/bcm2835.h [] > @@ -163,8 +163,10 @@ int bcm2835_audio_write(struct bcm2835_alsa_stream *alsa_stream, > unsigned int count, > void *src); > void bcm2835_playback_fifo(struct bcm2835_alsa_stream *alsa_stream); > -unsigned int bcm2835_audio_retrieve_buffers(struct bcm2835_alsa_stream *alsa_stream); > +unsigned int bcm2835_audio_retrieve_buffers( > + struct bcm2835_alsa_stream *alsa_stream); This is not a good change. This line exceeds 80 columns only because it uses very long identifiers (30+ chars). Anything that uses these very long names is going to be silly looking when forced to use 80 column line length maximums. Basically, it's OK as it is and if you really want to change it for any reason the other style to use is to have the return value on a separate line like: unsigned int bcm2836_audio_retrieve_buffers(struct bcm2835_also_stream *alsa_stream); Even so, that's not a good change either.