From: Joe Perches <joe@perches.com>
To: Arushi Singhal <arushisinghal19971997@gmail.com>,
gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: ks7010: Unnecessary parentheses should be avoided
Date: Sat, 18 Feb 2017 11:15:02 -0800 [thread overview]
Message-ID: <1487445302.2198.24.camel@perches.com> (raw)
In-Reply-To: <20170218160257.GA6915@arushi-HP-Pavilion-Notebook>
On Sat, 2017-02-18 at 21:32 +0530, Arushi Singhal wrote:
> Unnecessary parentheses as reported by checkpatch.pl
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -121,19 +121,19 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
> }
>
> /* bssid */
> - memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
> + memcpy(&ap->bssid[0], &ap_info->bssid[0], ETH_ALEN);
It's often nicer to read if &(foo[0]) is converted to foo like:
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
next prev parent reply other threads:[~2017-02-18 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 16:02 [PATCH] staging: ks7010: Unnecessary parentheses should be avoided Arushi Singhal
2017-02-18 19:15 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-18 16:58 Arushi Singhal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487445302.2198.24.camel@perches.com \
--to=joe@perches.com \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox