From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753741AbdBRTQE (ORCPT ); Sat, 18 Feb 2017 14:16:04 -0500 Received: from smtprelay0117.hostedemail.com ([216.40.44.117]:57204 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753357AbdBRTQC (ORCPT ); Sat, 18 Feb 2017 14:16:02 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3867:3871:3872:4321:5007:7903:10004:10400:10848:11026:11232:11658:11914:12043:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21060:21080:21433:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: self20_2c4ad0ff18f22 X-Filterd-Recvd-Size: 1435 Message-ID: <1487445302.2198.24.camel@perches.com> Subject: Re: [PATCH] staging: ks7010: Unnecessary parentheses should be avoided From: Joe Perches To: Arushi Singhal , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Date: Sat, 18 Feb 2017 11:15:02 -0800 In-Reply-To: <20170218160257.GA6915@arushi-HP-Pavilion-Notebook> References: <20170218160257.GA6915@arushi-HP-Pavilion-Notebook> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-02-18 at 21:32 +0530, Arushi Singhal wrote: > Unnecessary parentheses as reported by checkpatch.pl [] > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c [] > @@ -121,19 +121,19 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) > } > > /* bssid */ > - memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN); > + memcpy(&ap->bssid[0], &ap_info->bssid[0], ETH_ALEN); It's often nicer to read if &(foo[0]) is converted to foo like: memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);