From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753976AbdBRTWF (ORCPT <rfc822;w@1wt.eu>);
        Sat, 18 Feb 2017 14:22:05 -0500
Received: from smtprelay0158.hostedemail.com ([216.40.44.158]:40493 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1753555AbdBRTWE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 18 Feb 2017 14:22:04 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:3868:3873:4321:5007:10004:10400:10848:11232:11658:11914:12043:12296:12740:12760:12895:13069:13255:13311:13357:13439:14659:14721:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: kitty62_65613929dad28
X-Filterd-Recvd-Size: 1704
Message-ID: <1487445694.2198.26.camel@perches.com>
Subject: Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed
 unnecessary parentheses
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
        simran singhal <singhalsimran0@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Date: Sat, 18 Feb 2017 11:21:34 -0800
In-Reply-To: <alpine.DEB.2.20.1702182012240.2383@hadrien>
References: <20170218183648.GA2680@singhal-Inspiron-5558>
         <alpine.DEB.2.20.1702182012240.2383@hadrien>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.3-0ubuntu0.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote:
> On Sun, 19 Feb 2017, simran singhal wrote:
> > Extra parentheses were causing checkpatch issues
> > and were removed.
[]
> > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
[]
> > @@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
> >  	pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
> >  	pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
> > 
> > -	memset((void *)(&(pHTInfo->SelfHTCap)), 0,
> > +	memset((void *)(&pHTInfo->SelfHTCap), 0,
> 
> You don't need the parens around the argument of the cast either.

Nor need the cast at all.

	memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap));

etc...