From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751017AbdBUJSW (ORCPT ); Tue, 21 Feb 2017 04:18:22 -0500 Received: from smtprelay0142.hostedemail.com ([216.40.44.142]:39300 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751335AbdBUJSI (ORCPT ); Tue, 21 Feb 2017 04:18:08 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:421:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2110:2393:2553:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3873:3874:4321:5007:10004:10400:10848:11232:11658:11914:12663:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21324:30054:30069:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: birds67_63b1a1daf9e1c X-Filterd-Recvd-Size: 1582 Message-ID: <1487668683.2853.18.camel@perches.com> Subject: Re: [PATCH] drm: drm_printer: add __printf validation From: Joe Perches To: Jani Nikula , Eric Engestrom Cc: Rob Clark , Daniel Vetter , Sean Paul , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Date: Tue, 21 Feb 2017 01:18:03 -0800 In-Reply-To: <871surlxwv.fsf@intel.com> References: <87a89gkl09.fsf@intel.com> <1487665979.2853.16.camel@perches.com> <871surlxwv.fsf@intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-02-21 at 11:02 +0200, Jani Nikula wrote: > On Tue, 21 Feb 2017, Joe Perches wrote: > > On Tue, 2017-02-21 at 10:26 +0200, Jani Nikula wrote: > > > You know how this stuff works, please split it up to get the stuff > > > merged. > > > > Quite well actually. > > > > Fix it as you think appropriate. > > But in any case, fix it. > > Yes, I'm sure someone will eventually send patches I can apply. As you know it's a defect, you or one of the other maintainers of that file should fix it and not wait for what you consider the ideal patch. cheers, Joe