From: Mike Galbraith <efault@gmx.de>
To: Joerg Roedel <jroedel@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [bisection] b0119e87083 iommu: Introduce new 'struct iommu_device' ==> boom
Date: Tue, 21 Feb 2017 18:04:03 +0100 [thread overview]
Message-ID: <1487696643.21852.13.camel@gmx.de> (raw)
In-Reply-To: <20170221151926.GB4154@suse.de>
On Tue, 2017-02-21 at 16:19 +0100, Joerg Roedel wrote:
> Hi Mike,
>
> thanks for the report, this didn't trigger in my local testing here.
> Loosk like I need to test without intel_iommu=on too :/
>
> Anyway, can you check whether the attached patch helps?
Yup, boots.
> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
> index d9c0decfc91a..a74fec8d266a 100644
> --- a/drivers/iommu/dmar.c
> +++ b/drivers/iommu/dmar.c
> @@ -1108,8 +1108,10 @@ static int alloc_iommu(struct dmar_drhd_unit
> *drhd)
>
> static void free_iommu(struct intel_iommu *iommu)
> {
> - iommu_device_sysfs_remove(&iommu->iommu);
> - iommu_device_unregister(&iommu->iommu);
> + if (intel_iommu_enabled) {
> + iommu_device_sysfs_remove(&iommu->iommu);
> + iommu_device_unregister(&iommu->iommu);
> + }
>
> if (iommu->irq) {
> if (iommu->pr_irq) {
prev parent reply other threads:[~2017-02-21 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 14:55 [bisection] b0119e87083 iommu: Introduce new 'struct iommu_device' ==> boom Mike Galbraith
2017-02-21 15:19 ` Joerg Roedel
2017-02-21 17:04 ` Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487696643.21852.13.camel@gmx.de \
--to=efault@gmx.de \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox