From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753893AbdBURER (ORCPT ); Tue, 21 Feb 2017 12:04:17 -0500 Received: from mout.gmx.net ([212.227.15.19]:63010 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555AbdBUREK (ORCPT ); Tue, 21 Feb 2017 12:04:10 -0500 Message-ID: <1487696643.21852.13.camel@gmx.de> Subject: Re: [bisection] b0119e87083 iommu: Introduce new 'struct iommu_device' ==> boom From: Mike Galbraith To: Joerg Roedel Cc: LKML Date: Tue, 21 Feb 2017 18:04:03 +0100 In-Reply-To: <20170221151926.GB4154@suse.de> References: <1487688906.21852.11.camel@gmx.de> <20170221151926.GB4154@suse.de> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:DJoVY9AmY3GUDbdtsTzn8neShTRz/uziujIoyNgd7KKDlJiRgDF uccSdDZ2ID+JqPfo8TnOailVePl78tFuG5Vwtp/1QR2wPUtevSivj4hHFxi1APgSm3pQCP6 Jb0LE1zooo3vABrVrWRV9yeXktS07PiN7si5MuatV9IY8J0Ajd7IAudPRd85RvbW8DKspSD kEr4W5VQNezzeb2zQ6/UA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZWiBi3fdr+g=:k5/BjUwhoWy4chrJqCYiVJ zNumwhnkV8PnSTVkat2l44oKv3esuaL+mdUvyiBJlOyjqwV3JeC90bew5DM7EHU7YtbgI0dXs rXOl/Od8yHNmcIuedmVFZFxY65/hcu2VCOW3bZH83BzG1AhjB4VO/iiF05gmmNDHd/lWIpLfp K1dWQDBFNeqffOAfCUDBJ50qJekkJWCuL/tLvNgJF45R39p5cAs2qZDWwyO5UovQkKW3WV2Gp ahChnpvR1epJ9/EYzmAFH7LfMpAG/z9pIRJJRIeAsAmXKF8/GVUqbHhr4ERMqOW2oDttarLWu TZeB+RAkfn/oDZwtDkEOXg+m7UsxujY3PMxSMewtfFwSmXXeHMAfP6Wibux+ZN/ZZvEAg/PMB zOIkf8DX9Y0RqIsrOydnld0LM0eBx4Z5w6aBPVYmOA8Vh11seVUjpvgq3wdG+v4zMO5tafUQs G10w+hb/KhBx34vKaSzOmdg0mkswl9HjvcFLM8vtwEzJFjgVwsgRKqsE4szzf63rsVMX2RXDk 7l0b7oN2D6YjLwP7eVEZZmLk+/1z/P0T75Iy67bwO7tEno5bb3XBBLn59LHqK7zAWfSwj0tzk 7ll8qvyfW8hWNb0e3iShIXJYBb5qAueXfaGihFxeYotZXcC+8GANMQ4yLUu5D0NOQDjIczuOi LzipewolHWNdlmmbBvPdeBOLKhkquGUX4DieQzRjHpja1KDALCLr9qL4gPPPcMLmqwPwkqTgw r29W3EbaDDbvq84HaNg7DLm1F8jDPMtdKFnptopyIxA+WXih7FJjWkOHhvzanDHe8rrK7ebam qzgrygi Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-02-21 at 16:19 +0100, Joerg Roedel wrote: > Hi Mike, > > thanks for the report, this didn't trigger in my local testing here. > Loosk like I need to test without intel_iommu=on too :/ > > Anyway, can you check whether the attached patch helps? Yup, boots. > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c > index d9c0decfc91a..a74fec8d266a 100644 > --- a/drivers/iommu/dmar.c > +++ b/drivers/iommu/dmar.c > @@ -1108,8 +1108,10 @@ static int alloc_iommu(struct dmar_drhd_unit > *drhd) > > static void free_iommu(struct intel_iommu *iommu) > { > - iommu_device_sysfs_remove(&iommu->iommu); > - iommu_device_unregister(&iommu->iommu); > + if (intel_iommu_enabled) { > + iommu_device_sysfs_remove(&iommu->iommu); > + iommu_device_unregister(&iommu->iommu); > + } > > if (iommu->irq) { > if (iommu->pr_irq) {