From: Joe Perches <joe@perches.com>
To: Cheah Kok Cheong <thrust73@gmail.com>,
Valentin Rothberg <valentinrothberg@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple line dereference
Date: Tue, 21 Feb 2017 09:22:25 -0800 [thread overview]
Message-ID: <1487697745.2853.20.camel@perches.com> (raw)
In-Reply-To: <20170221163141.GA22866@linux-Precision-WorkStation-T5500>
On Wed, 2017-02-22 at 00:31 +0800, Cheah Kok Cheong wrote:
> > Another option could be using the typedefs from include/linux/types.h,
> > e.g. ushort. However, this might require changing other declarations as
> > well to keep consistency.
>
> Thanks for the idea. I counted seven instances of 'unsigned short'
> in this file so it's not viable for our situation.
I believe using ushort is relatively undesirable as
"unsigned short" is preferred ~10:1 in the kernel
$ git grep -w ushort | wc -l
1381
$ git grep -E "\bunsigned\s+short\b" | wc -l
11288
$ git grep --name-only -w "ushort" | wc -l
129
$ git grep --name-only -E "\bunsigned\s+short\b" | wc -l
2497
next prev parent reply other threads:[~2017-02-21 17:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 8:28 [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple line dereference Cheah Kok Cheong
2017-02-20 10:03 ` Ian Abbott
2017-02-20 16:02 ` Cheah Kok Cheong
2017-02-20 17:36 ` Ian Abbott
2017-02-21 9:33 ` Cheah Kok Cheong
2017-02-21 10:12 ` Ian Abbott
2017-02-21 10:20 ` Valentin Rothberg
2017-02-21 16:31 ` Cheah Kok Cheong
2017-02-21 17:22 ` Joe Perches [this message]
2017-02-22 8:30 ` Valentin Rothberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487697745.2853.20.camel@perches.com \
--to=joe@perches.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thrust73@gmail.com \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox