From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754531AbdBUSsi (ORCPT ); Tue, 21 Feb 2017 13:48:38 -0500 Received: from smtprelay0053.hostedemail.com ([216.40.44.53]:59950 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752985AbdBUSrg (ORCPT ); Tue, 21 Feb 2017 13:47:36 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3874:4321:4605:4823:5007:7903:10004:10400:10848:10967:11026:11232:11658:11914:12043:12438:12679:12740:12760:12895:13069:13141:13230:13311:13357:13439:14096:14097:14181:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: honey20_7c1652958f63a X-Filterd-Recvd-Size: 2100 Message-ID: <1487702851.2853.25.camel@perches.com> Subject: Re: [PATCH] staging/ks7010: formatting updates. From: Joe Perches To: Matthew Giassa , Geert Uytterhoeven Cc: Wolfram Sang , Greg KH , "linux-kernel@vger.kernel.org" , Linux-Renesas , driverdevel Date: Tue, 21 Feb 2017 10:47:31 -0800 In-Reply-To: <20170221173212.bhcqevjoatixnekz@darkstar> References: <1487650805-30520-1-git-send-email-matthew@giassa.net> <20170221141256.gowusquywtvyr7ac@shinestorm> <20170221173212.bhcqevjoatixnekz@darkstar> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: > * Geert Uytterhoeven [2017-02-21 15:22:10 +0100]: > > > The first declaration fit nicely on a single line. > > The second one indeed has a few spaces instead of TABs in the > > continuation line. But that can be fixed easily, without moving the > > first parameter to a continuation line. > > What would the proposed fix be? A combination of spaces and hard-tabs? I > don't see checkpatch complaining about it, so that could work too. Maximal initial tabs, followed by required spaces to align to open parenthesis So from: int ks_wlan_setup_parameter(struct ks_wlan_private *priv, unsigned int commit_flag); (2 tabs followed by 13 spaces) to: int ks_wlan_setup_parameter(struct ks_wlan_private *priv, unsigned int commit_flag); (3 tabs followed by 4 spaces)