From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754432AbdBUUC6 (ORCPT ); Tue, 21 Feb 2017 15:02:58 -0500 Received: from smtprelay0190.hostedemail.com ([216.40.44.190]:47580 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754242AbdBUUCv (ORCPT ); Tue, 21 Feb 2017 15:02:51 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4823:5007:7903:10004:10128:10400:10848:10967:11232:11658:11914:12219:12740:12760:12895:13069:13141:13230:13311:13357:13439:14096:14097:14181:14659:14721:21080:30054:30070:30074:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: dad23_359607b80790c X-Filterd-Recvd-Size: 2419 Message-ID: <1487707366.2853.31.camel@perches.com> Subject: Re: [PATCH] staging/ks7010: formatting updates. From: Joe Perches To: Matthew Giassa Cc: Geert Uytterhoeven , Wolfram Sang , Greg KH , "linux-kernel@vger.kernel.org" , Linux-Renesas , driverdevel Date: Tue, 21 Feb 2017 12:02:46 -0800 In-Reply-To: <20170221194833.b34zc5iqxrydadrt@darkstar> References: <1487650805-30520-1-git-send-email-matthew@giassa.net> <20170221141256.gowusquywtvyr7ac@shinestorm> <20170221173212.bhcqevjoatixnekz@darkstar> <1487702851.2853.25.camel@perches.com> <20170221194833.b34zc5iqxrydadrt@darkstar> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-02-21 at 11:48 -0800, Matthew Giassa wrote: > * Joe Perches [2017-02-21 10:47:31 -0800]: > > > On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: > > > * Geert Uytterhoeven [2017-02-21 15:22:10 +0100]: > > > > > > > The first declaration fit nicely on a single line. > > > > The second one indeed has a few spaces instead of TABs in the > > > > continuation line. But that can be fixed easily, without moving the > > > > first parameter to a continuation line. > > > > > > What would the proposed fix be? A combination of spaces and hard-tabs? I > > > don't see checkpatch complaining about it, so that could work too. > > > > Maximal initial tabs, followed by required spaces to align > > to open parenthesis > > > > Thank you Joe. I will change it accordingly. Is there a supplementary > style guide that covers these finer details? No, coding style just says Descendants are always substantially shorter than the parent and are placed substantially to the right However alignment to the open parenthesis is a pretty common style.