From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
simran singhal <singhalsimran0@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 2/7] staging: most: Using macro DIV_ROUND_UP
Date: Wed, 22 Feb 2017 02:07:55 -0800 [thread overview]
Message-ID: <1487758075.14159.3.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1702221025550.3145@hadrien>
On Wed, 2017-02-22 at 10:27 +0100, Julia Lawall wrote:
> > @@ -117,7 +118,7 @@ static int alloc_dbr(u16 size)
> > return DBR_SIZE; /* out of memory */
> >
> > for (i = 0; i < DBR_MAP_SIZE; i++) {
> > - u32 const blocks = (size + DBR_BLOCK_SIZE - 1) / DBR_BLOCK_SIZE;
> > + u32 const blocks = DIV_ROUND_UP(size, DBR_BLOCK_SIZE);
> > u32 mask = ~((~(u32)0) << blocks);
>
> Totally unrelated to DIV_ROUND_UP, would this code be a candidate for
> GENMASK?
Maybe "(1 << blocks) - 1" would be more intelligible.
next prev parent reply other threads:[~2017-02-22 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 9:10 [PATCH v2 2/7] staging: most: Using macro DIV_ROUND_UP simran singhal
2017-02-22 9:27 ` [Outreachy kernel] " Julia Lawall
2017-02-22 10:07 ` Joe Perches [this message]
[not found] ` <d1716b00-a408-4f3c-8c17-04a70acca4dd@googlegroups.com>
2017-02-22 11:36 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487758075.14159.3.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox