From: Mike Galbraith <efault@gmx.de>
To: Alex Shi <alex.shi@linaro.org>, Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: 9908859acaa9 cpuidle/menu: add per CPU PM QoS resume latency consideration
Date: Wed, 22 Feb 2017 15:46:40 +0100 [thread overview]
Message-ID: <1487774800.4487.15.camel@gmx.de> (raw)
In-Reply-To: <ac73da0c-4a0d-c36b-9d5a-fe88de3a1acf@linaro.org>
On Wed, 2017-02-22 at 22:31 +0800, Alex Shi wrote:
>
> On 02/22/2017 09:19 PM, Mike Galbraith wrote:
> > On Wed, 2017-02-22 at 14:12 +0100, Peter Zijlstra wrote:
> > > On Wed, Feb 22, 2017 at 01:56:37PM +0100, Mike Galbraith wrote:
> > > > Hi,
> > > >
> > > > Do we really need a spinlock for that in the idle loop?
> > >
> > > Urgh, that's broken on RT, you cannot schedule the idle loop.
> >
> > That's what made me notice the obnoxious little bugger.
>
> Hi Mike,
>
> Sorry for this bug. Guess the rt_spin_lock call some function in
> rtmutex.c:995. Could you like to show me how to reproduce this bug?
Yeah, spinlock_t is transmogrified into an rtmutex in RT trees. No
need to reproduce, if you just make the lock go away, RT trees will
become happy camper again, and NONRT trees won't have to feed yet
another an cycle sucking lock in the fastpath.
-Mike
next prev parent reply other threads:[~2017-02-22 14:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 12:56 9908859acaa9 cpuidle/menu: add per CPU PM QoS resume latency consideration Mike Galbraith
2017-02-22 13:12 ` Peter Zijlstra
2017-02-22 13:19 ` Mike Galbraith
2017-02-22 14:31 ` Alex Shi
2017-02-22 14:39 ` Peter Zijlstra
2017-02-22 14:55 ` Alex Shi
2017-02-23 12:15 ` Rafael J. Wysocki
2017-02-23 13:08 ` Mike Galbraith
2017-02-23 13:58 ` Alex Shi
2017-02-23 13:55 ` Alex Shi
2017-02-23 22:34 ` Rafael J. Wysocki
2017-02-24 1:49 ` Alex Shi
2017-02-24 12:25 ` [PATCH] cpuidle: menu: Avoid taking spinlock for accessing QoS values Rafael J. Wysocki
2017-02-22 14:46 ` Mike Galbraith [this message]
2017-02-22 14:53 ` 9908859acaa9 cpuidle/menu: add per CPU PM QoS resume latency consideration Alex Shi
2017-02-22 15:03 ` Mike Galbraith
2017-02-22 15:36 ` Alex Shi
2017-02-22 15:46 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487774800.4487.15.camel@gmx.de \
--to=efault@gmx.de \
--cc=alex.shi@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox