From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751277AbdBWNeY (ORCPT <rfc822;w@1wt.eu>);
        Thu, 23 Feb 2017 08:34:24 -0500
Received: from smtprelay0147.hostedemail.com ([216.40.44.147]:42780 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751049AbdBWNeX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Feb 2017 08:34:23 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1515:1516:1518:1534:1538:1561:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3876:3877:4321:5007:6114:6642:6742:10004:10400:10848:11026:11658:11914:12043:12296:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21094:21323:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: talk08_7cb6b85b03363
X-Filterd-Recvd-Size: 1735
Message-ID: <1487856855.14159.26.camel@perches.com>
Subject: Re: [PATCH] staging: speakup: synth: Fix checkpatch warning
From: Joe Perches <joe@perches.com>
To: Man Choy <manchoyy@gmail.com>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
        Chris Brannon <chris@the-brannons.com>, Kirk Reiser <kirk@reisers.ca>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Walt Feasel <waltfeasel@gmail.com>,
        Amitoj Kaur Chawla <amitoj1606@gmail.com>,
        Colin Ian King <colin.king@canonical.com>,
        Katie Dunne <kdunne@mail.ccsf.edu>, speakup@linux-speakup.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Thu, 23 Feb 2017 05:34:15 -0800
In-Reply-To: <1487855731-18879-1-git-send-email-manchoyy@gmail.com>
References: <1487855731-18879-1-git-send-email-manchoyy@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.3-0ubuntu0.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2017-02-23 at 21:15 +0800, Man Choy wrote:
[]
> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
[]
> @@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth)
>  	if (!spk_quiet_boot)
>  		synth_printf("%s found\n", synth->long_name);
>  	if (synth->attributes.name && sysfs_create_group(speakup_kobj,
> -							 &synth->attributes) < 0)
> +		&synth->attributes) < 0)

Better would be

	if (synth->attributes.name &&
	    sysfs_create_group(speakup_kobj, &synth->attributes) < 0)