From: Joe Perches <joe@perches.com>
To: Yamanappagouda Patil <goudapatilk@gmail.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH] staging: vc04_services: Fixed "space prohibited after that open/close parenthesis" erros.
Date: Thu, 23 Feb 2017 10:15:55 -0800 [thread overview]
Message-ID: <1487873755.14159.43.camel@perches.com> (raw)
In-Reply-To: <1487860253-6840-1-git-send-email-goudapatilk@gmail.com>
On Thu, 2017-02-23 at 20:00 +0530, Yamanappagouda Patil wrote:
> Fixed checkpath.pl erros "space prohibited after that open/close parenthesis" in vchiq_version.c file.
>
> Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com>
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_version.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c
[]
> @@ -33,27 +33,27 @@
> #include "vchiq_build_info.h"
> #include <linux/broadcom/vc_debug_sym.h>
>
> -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_hostname, "dc4-arm-01" );
> -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_version, "9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)" );
> -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_time, __TIME__ );
> -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_date, __DATE__ );
> +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_hostname, "dc4-arm-01");
> +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_version, "9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)");
> +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_time, __TIME__);
> +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_date, __DATE__);
Uses of __TIME__ and __DATE__ make it
impossible to have repeatable builds.
Are these __TIME__ and __DATE__ uses
really useful and necessary?
next prev parent reply other threads:[~2017-02-23 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 14:30 [PATCH] staging: vc04_services: Fixed "space prohibited after that open/close parenthesis" erros Yamanappagouda Patil
2017-02-23 18:15 ` Joe Perches [this message]
2017-02-24 17:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487873755.14159.43.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=goudapatilk@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox