From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Brian Norris <briannorris@chromium.org>
Cc: Andy Whitcroft <apw@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: don't complain on module_param(foo, bar, 0)
Date: Thu, 23 Feb 2017 14:20:29 -0800 [thread overview]
Message-ID: <1487888429.14159.48.camel@perches.com> (raw)
In-Reply-To: <CAHp75VdL5b66VzuuMc=xKprz7OLj8yRXSR9n_i_yt1h_P=H9eg@mail.gmail.com>
On Fri, 2017-02-24 at 00:10 +0200, Andy Shevchenko wrote:
> On Thu, Feb 9, 2017 at 2:05 AM, Brian Norris <briannorris@chromium.org> wrote:
> > The following code snippet:
> >
> > module_param(writeable, bool, 0);
> >
> > yields this warning:
> >
> > ERROR: Use 4 digit octal (0777) not decimal permissions
> > #390: FILE: drivers/mtd/spi-nor/intel-spi.c:143:
> > +module_param(writeable, bool, 0);
> > total: 1 errors, 0 warnings, 1006 lines checked
> >
> > But 0000 is no easier to read than 0, and module_param() even
> > specifically refers to 0.
>
> While this is all correct, the question is why we disallow to read
> back on those parameters?
why disallow root to read-back any parameter?
prev parent reply other threads:[~2017-02-23 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 0:05 [PATCH] checkpatch: don't complain on module_param(foo, bar, 0) Brian Norris
2017-02-23 22:10 ` Andy Shevchenko
2017-02-23 22:20 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487888429.14159.48.camel@perches.com \
--to=joe@perches.com \
--cc=andy.shevchenko@gmail.com \
--cc=apw@canonical.com \
--cc=briannorris@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox