From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751379AbdBWWUf (ORCPT <rfc822;w@1wt.eu>);
        Thu, 23 Feb 2017 17:20:35 -0500
Received: from smtprelay0001.hostedemail.com ([216.40.44.1]:44362 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751223AbdBWWUd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Feb 2017 17:20:33 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:4321:5007:6119:7903:10004:10400:10848:11232:11658:11914:12043:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21451:30012:30041:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: women04_3eca95b29bf33
X-Filterd-Recvd-Size: 1693
Message-ID: <1487888429.14159.48.camel@perches.com>
Subject: Re: [PATCH] checkpatch: don't complain on module_param(foo, bar, 0)
From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
        Brian Norris <briannorris@chromium.org>
Cc: Andy Whitcroft <apw@canonical.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date: Thu, 23 Feb 2017 14:20:29 -0800
In-Reply-To: <CAHp75VdL5b66VzuuMc=xKprz7OLj8yRXSR9n_i_yt1h_P=H9eg@mail.gmail.com>
References: <20170209000501.114206-1-briannorris@chromium.org>
         <CAHp75VdL5b66VzuuMc=xKprz7OLj8yRXSR9n_i_yt1h_P=H9eg@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.3-0ubuntu0.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2017-02-24 at 00:10 +0200, Andy Shevchenko wrote:
> On Thu, Feb 9, 2017 at 2:05 AM, Brian Norris <briannorris@chromium.org> wrote:
> > The following code snippet:
> > 
> >     module_param(writeable, bool, 0);
> > 
> > yields this warning:
> > 
> >     ERROR: Use 4 digit octal (0777) not decimal permissions
> >     #390: FILE: drivers/mtd/spi-nor/intel-spi.c:143:
> >     +module_param(writeable, bool, 0);
> >     total: 1 errors, 0 warnings, 1006 lines checked
> > 
> > But 0000 is no easier to read than 0, and module_param() even
> > specifically refers to 0.
> 
> While this is all correct, the question is why we disallow to read
> back on those parameters?

why disallow root to read-back any parameter?