From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751824AbdBXQRE (ORCPT ); Fri, 24 Feb 2017 11:17:04 -0500 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:8692 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751430AbdBXQQu (ORCPT ); Fri, 24 Feb 2017 11:16:50 -0500 X-IronPort-AV: E=Sophos;i="5.35,201,1483977600"; d="scan'208";a="96398991" Authentication-Results: spf=pass (sender IP is 74.221.232.55) smtp.mailfrom=sandisk.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac1c2134-b9d8b98000005688-44-58b05c619ad9 From: Bart Van Assche To: "hal.rosenstock@gmail.com" , "mnghuan@gmail.com" , "dledford@redhat.com" , "sean.hefty@intel.com" CC: "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" Subject: Re: [PATCH] ib_srp: Let compiler ignore the useless debug code Thread-Topic: [PATCH] ib_srp: Let compiler ignore the useless debug code Thread-Index: AQHSjrlc4ij62o0/Q0q+bMatX8oeqw== Date: Fri, 24 Feb 2017 16:16:31 +0000 Message-ID: <1487952911.2575.1.camel@sandisk.com> References: <20170224084451.42117-1-mnghuan@gmail.com> In-Reply-To: <20170224084451.42117-1-mnghuan@gmail.com> Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-Type: text/plain; charset="iso-8859-1" Content-ID: <19F6D91DE058AF44A730D92D2F228086@sandisk.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsWyRobxn25izIYIg/2HRS1env/AarFx80RG i8u75rBZPDvUy2Lx7vFVRovm9RtYHNg8ds66y+6xeM9LJo/3+66yeXzeJBfAEsVlk5Kak1mW WqRvl8CV8WTaXLaCX8wVD5pkGxj7mbsYOTkkBEwkpl+9zwRiCwksYZI4ft+li5ELyL7EKLG3 dT8LSIJNwEhi9oQ9LCAJEYFDjBLTb65nA0kwC9RJXNo6BaxIWMBd4v3ui2BTRQQ8JBrm/GSC sPUkdu9aBVbDIqAq8eDvAkYQm1fAUOJg/2xGiM1mEscuPAOzOQXMJT7dnQFUz8HBKCAr0fKa G2KVuMStJ/OZII4WkFiy5zzUA6ISLx//Y4WwFSQ+r/gHdZqexI2pU6BsK4kzvxaxQNjaEssW vmaGOEFQ4uTMJywTGMVmIVkxC0n7LCTts5C0z0LSvoCRdRWjWHFicnFuemqBoalecWJeSmZx tl5yfu4mRnBEKprsYOzY6H6IUYCDUYmHN8FmQ4QQa2JZcWUuMDQ5mJVEeM/bA4V4UxIrq1KL 8uOLSnNSiw8xSnOwKInzLtWeGiEkkJ5YkpqdmlqQWgSTZeLglGpgbDcOKzpev6Dh7NLMY9mP 9ecd+e3XdeDFCl6BLBtZY1uTH+sFOta8KHkQ+e3Yn2n3jy7+fs7xpf/RGT47TH5PlZ90PGWO /n7tQ89Y7z9S+mlzf76hFZf+jtNXSlgjKkzMDa7tbpIpmF7ssmSi4nzefw7yVUvjzu893uxw Y6tdjNiUPOHjZ8QXOCmxFGckGmoxFxUnAgD9FwXXxAIAAA== X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.55;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10019020)(979002)(6009001)(7916002)(39450400003)(39850400002)(39410400002)(39860400002)(39840400002)(2980300002)(438002)(199003)(24454002)(189002)(377424004)(8746002)(356003)(23756003)(86362001)(33646002)(8936002)(8676002)(103116003)(81156014)(305945005)(97736004)(38730400002)(81166006)(50466002)(6246003)(2501003)(189998001)(2270400002)(47776003)(2201001)(106116001)(4326007)(36756003)(92566002)(106466001)(6116002)(54356999)(69596002)(626004)(39060400002)(2950100002)(2906002)(7736002)(68736007)(5660300001)(76176999)(3846002)(54906002)(50986999)(102836003)(53936002)(2900100001)(229853002)(7099028)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR04MB0746;H:sacsmgep15.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3NAM04FT055;1:m2KbdDr24vdDBfX0CyhKLGNyMJ7VHM1S4UAuNbeeuerXuPSO9gKximRVCONBg4dcbMNSjuqNweuBpYtvRDcZsL0X3XYCLfeMTX4ZY+cndbEWssd/fI/Ww0GQlSBKDbQc1EGIjh94M8fC/uK1HZzndikSMAhcNyMx0xDd3uGU1fh78ADE84sZt8sAF5vkCS8oVVBSzSfQvH0Wjd0AJX9uPYXW50KpBEtIuB3ANsN+n6B6YWGKBi7LcfmNfj9/Zu4oQHet3xRKqKIG/m3eSacflpYJH/8rMffoIpzZBL8zDH6uRXSKjSkRGRDLC6lBVBY9p4mTfFPZJmR+wZd8GZLh3cctsH5bjetEM1IRvSTxrOZ048bJY7evJgb/uQiTxts7Ud1JUMxQARbaJuB84FmqZjsx8h4W+D2zPmlAGkth4F6Xaqp/TZrZEjtFaXBU3F9b9u1ArnI6vYMHqG5n4vBrcon+NSbMzSeZnGhVvQeSInuzpLxuJ1aOmr8XthgLbcItOZPhKyjdP+HEPHGO3KaJuVaJIlSV71ZA6sD+ltCRUAgyifYaaCIAkyLrdO4NTyHb X-MS-Office365-Filtering-Correlation-Id: eae8717d-3231-4936-0517-08d45cd080cf X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:DM5PR04MB0746; X-Microsoft-Exchange-Diagnostics: 1;DM5PR04MB0746;3:bxLNqqPt0BhiiWX0xxiYtolAS8+mP+NPEdfrw3C4yD9SN+vPDfhva6pfP5m6nNTLePLvU1UETwN9G2foG5VxWU3u9/vR1A9NE7HzQ2J/+wSeic/RpXfhhD9TedVx9zfLYu1GYDNoiXKBeHFt51aajh55m9+RA9ITwSsFeG5elSdxuMSBuQXPzZ7mHN7M6hTicqbNE/07fI66eR1gSNbJ6e4+LUzUVc9sUHtOk7EJpggoYjQS96mEygdWHZ0CRbdZeMGwdFYXPYTWGbrkBzSzP8bVKBRTNktu7aLHhLyZTmFz8Uc6rr5ZTok3UQVvloY32hMzOSFMswZ6szd+CRY7hSM2vUm7bbMmDTrmVK+MkLv2SIRBNl33Fnk1vd6uCfIwXOaEGj3YLeImLDg1kbCWrA==;25:COdEHjsKknRWoChP6THuIH3DIdfcORUkO9fZNRDe0rARSRNwvRC7aA/z8HcT3VcEZmcOrKH10MYAQKPGhGqIp5kp82rHgmA4HA1ATy3yQ6mYCmFvHm4NpooTXUQRITvU1VPmVZXHhOZKTl7Nxb+Eh9k5+8fPuktMoUegCD10GTzSTxzy5ektRpC2TzGDUAVGYepE5b3BGPPZJWxDMHAaQ03yhkr5NiOqaTJzj4rqTI/FgR1VKxea4h3P71sh/v/I6c+/MMmrdDjxbElMA/AkdDTsImED7tvTaMyQs8HNjB8ClB3maTV3Q0X2AI5Hwv/Uuz81Ot0Yn2mW4d/abf8KFJmuDr33dVa8B28QeDBPNEX5oHT3ykJxSPx9L0fqAyse/JlXfwtCU5zi1xLpzuL9tB6RxFc8iZKPggSvkXvLSj5+GSJ9ttdlHyyRz5fbYIYclFX5083xspP6wgXHW4oOaw== X-Microsoft-Exchange-Diagnostics: 1;DM5PR04MB0746;31:UAzF2GiQLAx5tE+mrINPuW0v62qlZIpxZJEhzjeMq1rJodtBoA8/WvH1lJtFq2X1uvIS9DuSY6ESfhl0jxuMhfs14/voGTa3g2qgN+HZyPOJmQ2Bv0sDKTY0EdhC6EDTzfU9WSefflgZ6kRCjY+H2f28KluhhBtSa8TZWm2ZgcfF7x17JwHhhn2EoTZzhsolpYh+bUXzU37TpwsGWE19Da6gujTdGhTiAi6Ie+kQdkdlsPYJTczdgehFuajAoFgia6fWzoE05OMPNW/mYg71b9zUkeYfJKIg9z1nIsKMZmg=;20:cUUIzSwq5bu2dtNhPHUN1B4DMgInMx0L+Ws7a59w6wwfYpWrd+dis1Vj9ZJmqU0gexA/AUZnQ6LYsuk7dNVwiuGwFCptl4YJecbo7vTStod8fkVfEo/lTlgm46qfVimZKBXP40Y5xfagzPvRGEovUc1PkvH8Q2ProwVjVWyorU+np9Zon9fPYHU/b6Si3xI0Cp0LQdBLCcDVOfXwtyz9+2EU9jXcWq/fqGFyXFq846ZDQNOESUCL5x9uP+CdMt3uiqRzVrMBd6XV+kV2WWnxypRrBlTiiCvQm/W5pHbkSo1+eyolhap/q82Evgprjs1bvoex/E6jWEKScREzaqvxi/cst6mGE00JnxEb5md/I/i35TOg6nKHkpzMB12Q49LQ7v6B7tWOQPgDMg3q72zptIQnMaVxz5H2Vm/XlRb5VVoEewpYzHgsPSjYDtS7cIWdOmmpiGeXH3mLY4AV5LSz0vW8sO/MAxQ9Ja7bALpFp1fEsIOx4WKalJyjBWoF+VCw X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13015025)(8121501046)(5005006)(13023025)(13017025)(13024025)(13018025)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(20161123558025)(6072148);SRVR:DM5PR04MB0746;BCL:0;PCL:0;RULEID:;SRVR:DM5PR04MB0746; X-Microsoft-Exchange-Diagnostics: 1;DM5PR04MB0746;4:5QYoLvdRJTPOxHrDiata2q++ArzxB+XB2wXIiKme5Y6R4k2hCvSJMu7hL90GZmZgV1t/c5wFIzpTrMej9Wx4zwTX/BATqYBgaQzzq1x+9UphbCaAWulAn7Nj3BHqsx2nUBGUiDLvrTjMh0WeWLOorhgBw81Ppa4puofSlcAPbTw3TXSFPdjL1L/NCYDC3e/oPbHoAKtHu1J9U2qfS8/iUs798xKfUBx7XZRz9KDYv8fwnmf7M12uKYVWMTGMy2t4G4cBl47IlLc6edbaJllTBFg+Vq7/lyqbQRH0mV7w93scoUaGgIy7rxX8Z2UWFN+5Ls6EAleGiadSyF6AF7p4ycAPMHn5qo8JNVyOH7JZCxpvncPkLuU3MCIvhsciShId8Vr9Xhm+DYtIV9FhqT+atPYHGg3iHpz/Ad6DzOYFNWiw+u2kR60NPIBmjkctgu8ZfkCgizGeENVGX4AoELwHyGskUFG52ow7opNG9QawOH3aPtUv8mCvXdWAYA133kqJrGfiQxFaFbzpQT/KRzF+ORP1Y5Uv7tWCVCMnZOz1GEVhICkkDcRScqQI7zO7pRWX0NueD9GeY/TBKPSrnDks3N1zw9P2xj6v3oIJOoLSe1Xrm55vcLx1E8oYi0AJnPxOOkii4mQzVsC4rtKQYmBY104Ch8pw2x7DLKiq4vd4giuShsvRhveBO7EcS677Z0A8Pk0yjRcR4TAPzNw88NhftQ== X-Forefront-PRVS: 0228DDDDD7 X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;DM5PR04MB0746;23:6ZJtZoEshZaFHXeB1IY+uLZSEROwAxxLSYaUrdB?= =?iso-8859-1?Q?Olg5WS6uvoCjUduwUwSUaywC7rT3VEay5f0B6szyXScCgxaSgD7x7TTzLn?= =?iso-8859-1?Q?IzPEVKWsYMcDuwPaXBCmQw2+/e88YSLHvUIwK+WgRSrX78fMBQdbAndB38?= =?iso-8859-1?Q?EXRltVzBRV5X+3pFrhk7qi7oStGOX/2NmuwSLXhH9KxnTvHqoF0esG0Z7Q?= =?iso-8859-1?Q?DQ/KWkI+lvEdYnguNT+XpHdCl0czqpysMcGIsUwG4Hj5F2v1AixhL/fhaZ?= =?iso-8859-1?Q?53L17tjwOCEC3Oqs2W+Zg06Cpq7EWgw6AClh7Pb6Awxyp7itoPVIYkByfU?= =?iso-8859-1?Q?/IaIjLdXemzBGnjz9QWGZyH5BdpzVFt2rO2v8Dt7AdgxGx5yn7Ky6fC8hh?= =?iso-8859-1?Q?gwUxHSuycF5KqUkjNZn94LuKg6cBzrd5IVTJC7XGsVctrUF1wYRLieO0kY?= =?iso-8859-1?Q?Rj4Cw6Y8jyPK21YD5qNjatgN9F8XV6r22reVEWlrtZM3O89DzcpanVsET6?= =?iso-8859-1?Q?o3cSSWDC6smzV204L8HEOm5WGQAC80PZFiKvexXKDJGaR3WHntKRksUC8D?= =?iso-8859-1?Q?JJyEWI13pYACitVlj1ZK320iStgYWqr+UkLcwbNePeV5pciUaWQcQfLyrA?= =?iso-8859-1?Q?XskaYi8E7WWjceCiBbdClVD6BZ8qVjGks6cZh/gO8MbqdwKI1i4xc/docZ?= =?iso-8859-1?Q?tj30uBrWbFpJxH/Cf3gPavi/T6loLDdFA/tPdfVJ1xOD73KdtkNI4xKkDP?= =?iso-8859-1?Q?TkHs8Us69ViUxr3CMq/y7WMGqbVm9Y0s9uTfxrxeDaXZs1MCyDligXpmcc?= =?iso-8859-1?Q?NoX9awQUGDnCITczg3moG4sRXOrr4YANJgaI8j5Uyw9SKEh0iGtErzEF62?= =?iso-8859-1?Q?2Zb9HrtDl4Zw3MmL8yKeBEhj1szmqYlVLqnqabeyf8CftNV7hn0MhJs5rs?= =?iso-8859-1?Q?CN8B+4gGud/FJTKSvJrdCah++RCS8Qo/ZIgt/HodEJ7CEl8er1HeIIK/pB?= =?iso-8859-1?Q?BNolz0GmwE2aF+7cqxW7sxoGaFkCoyDCNSkB4URipuc6FmTh3pwp0BSRuC?= =?iso-8859-1?Q?nwMmOal3iYVHz878W9YAHFWGr+/u/k2qFiYR4rcGvS33+UWBAVjjSH21Z/?= =?iso-8859-1?Q?lekqujsupaAdq0cTi93Fz7a5xBMG6S0RUJGf5YxhFLDXXm3VnATeC+vDzR?= =?iso-8859-1?Q?lh+OKghFL3sVA/rmbHXHITkEwOgDKg7rM7nQFjmKO6ffuL7NxyP+Mnmx6M?= =?iso-8859-1?Q?uZ0CdG/jlLIDYL7Ra7In98IqPXJIRnT/lkk3kMC2XwJQaP83YznRxLsHf5?= =?iso-8859-1?Q?XIg37pWDrNBSAuP59BNhsKoi83ZrEzuKB3tQsZeb61EScZl3ptjfhNIPbq?= =?iso-8859-1?Q?9nn9smagUTAviMEn2QZXmCryRRhJwrR47z4xKaCUQASbXhie64SqJOQXZ1?= =?iso-8859-1?Q?gme7QnpE5hYK/7sHlcNuKMffrxRw2/loiC5qgDRf+Q+iwC1F9mlTeqcBEH?= =?iso-8859-1?Q?UQzhpEvhQ/c/tcCay+dntZoLhqkNAqxkS3+J5ZE8b?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR04MB0746;6:L8OTZHivXHsxrio6g3aEkdkrn1LFbecWu0xLFJwYMxBb6BT0SWLhDSRXPDZYXJ5GXldxkUS+cOTQUvyu34i8zF3F9Rpff6XckZhBkxGA/ORaXf9L6HYmcU75XiRV8SK59N6yi+di7T0u68I9BX/Q1TEKm0JkNoOtSooe7avZiCNzXCKKO1dl/K/CEgEGSCNUIC+O8Lw6ipH6lgaJUxvmezHq059yRj1gd1ssFuWbnQgBujBPea3TPWah2ypjzdT1BQATc0KTdqhJtU8KGkiGZUkB3Jlxsabhjs7woY8X6RJjQuFgWFGDCQC7Ybp+KKg92R1FKxPs2gwYWOqtcFYR0vD+jJVdIlioZK6tYff2aPai+ho0XM7J8JHBcxNIRPDnMHHHsQ1qPQssInpEGG8Ohnv3mkmpfC99EbFuim5hwvA=;5:sm9QJE4r06dzcwh0SDwDSn6lLUPBrdEG2Ha7SB/8wPHIS6FFC8h/2ZmHbMyUZTxYTpdJJkfjFngssKiPEp0jV3bAGSaPKc9XH188Za4Q0PhyyjdkUJe0yHg0yJOmP7/bpvQ+w620jZ1gHI9+dxpQsg==;24:i7lytYvmo35qQLDyqcJoPbuiQJo76tuF0W+CY5pfqY2Xq4A1udK1XqXWsV8M4JPE8v6ThJn7yDjonL0rAuqNfZAzZYuaFPSPzRW6lw5+axw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR04MB0746;7:vyZCKxJShNzuvRDMcpa0JL/8YoZoV0koM/yeEF+XiQJMnIw0mrpBmVXxh8zDFRJPdbGyTFSuynZ1xY1hQJ4mrlvrV0JCjUDFOEfe6QifnTyMBfeskJmbDgAnwpdLdcI+GmlIfjtd6owsodX9Azgy4Ca0a9Y3Eyq90PBUGlRO3LtGn+PtkDFfFUSh9uO8gljRGC8TzSuNBNlNWC5AHalu3yKA9Dau+a4JD1wi29xtm/erU4mP0YnFR3RRWAGrCH1ELuZVtBmmrqsdheI+dGgpbNgzaIf1Jil1k4pmIKsJoJBwyBSnX5Lsm86A5S0T6pHDtyRvfsN+kKcm6l5fCzaz0w==;20:5ymOgyJkPe7GxB/q7l2luLqIhl3r9uytaTFGVG1HxbCLmr7NEwIoTtNgU3KXLBzGFWGifRfUlfJlNtoUrp2w/2r/3zKPJcir/vkevv0cu2E76VmN4UqYBpOiRbAm/FqiDWWJQT6rGn2SZUTXHTYj8WFvYMCW7XcddFG8DTixLVUqi/zVgGVV5DVlxk2KjHrLHWxX3jfdZEKPlGCUSmsjxfx1oWTCVkaRcMwDtzkMR5OuQ28GpLipT2baJTWwPLdn X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2017 16:16:34.2117 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86;Ip=[74.221.232.55];Helo=[sacsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB0746 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1OGH9IN024135 On Fri, 2017-02-24 at 16:44 +0800, Minfei Huang wrote: > "if (0)" is used to make this block of debug code not be executed. There > is a more elegant way to let compiler ignore this code, using > "#if 0 .. #endif" instead. > > Although it may be optimised by some compilers with specified parameter, > just for readable. #if 0 / #endif prevents the compiler from checking the syntax of the code. Such code tends to grow syntax errors. So I'm not sure this patch is an improvement. Bart.