linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Wang Nan <wangnan0@huawei.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Taeung Song <treeze.taeung@gmail.com>
Subject: [PATCH v2 0/3] perf annotate: Introduce the new source code view
Date: Wed,  1 Mar 2017 04:59:50 +0900	[thread overview]
Message-ID: <1488311993-15124-1-git-send-email-treeze.taeung@gmail.com> (raw)

Hi,

Currently perf-annotate have several problems.

  - Wrong line numbers on perf-annotate (both stdio and TUI)
  - Wrong sum of overhead(percent) matching source lines
  - It's so confusing that the output is mixed with
    both source code and assembly code. (related to depending on 'objdump -S')

So fix them regarding wrong line numbers
and Introduce new source_code collecting actual code,
not depending on 'objdump -S'.

I'd appreciate some feedback.

Thanks,
Taeung

v2:
- contains the new source code view (Namhyung)

Taeung Song (3):
  perf annotate: Get correct line numbers matched with addr
  perf annotate: Introduce the new source code view
  perf annotate: Support the new source code view for TUI

 tools/perf/builtin-annotate.c     |   2 +-
 tools/perf/ui/browsers/annotate.c | 175 ++++++++++++++++-------
 tools/perf/util/annotate.c        | 292 ++++++++++++++++++++++++++++++++++----
 tools/perf/util/annotate.h        |  28 ++++
 4 files changed, 419 insertions(+), 78 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-02-28 20:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 19:59 Taeung Song [this message]
2017-02-28 19:59 ` [PATCH v2 1/3] perf annotate: Get correct line numbers matched with addr Taeung Song
2017-03-01 13:17   ` Namhyung Kim
2017-03-02  6:05     ` Taeung Song
2017-03-03  2:40       ` Namhyung Kim
2017-03-03  3:25         ` Taeung Song
2017-02-28 19:59 ` [PATCH v2 2/3] perf annotate: Introduce the new source code view Taeung Song
2017-03-01 13:58   ` Namhyung Kim
2017-03-01 14:08     ` Peter Zijlstra
2017-03-01 14:21       ` Namhyung Kim
2017-03-01 14:30         ` Peter Zijlstra
2017-03-01 14:56           ` Namhyung Kim
2017-03-01 15:07             ` Peter Zijlstra
2017-03-01 15:52               ` Taeung Song
2017-03-03  5:09               ` Namhyung Kim
2017-02-28 19:59 ` [PATCH v2 3/3] perf annotate: Support the new source code view for TUI Taeung Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488311993-15124-1-git-send-email-treeze.taeung@gmail.com \
    --to=treeze.taeung@gmail.com \
    --cc=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).