From: simran singhal <singhalsimran0@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
sergio.paracuellos@gmail.com, juliana.orod@gmail.com,
thomas.petazzoni@free-electrons.com, noralf@tronnes.org,
outreachy-kernel@googlegroups.com
Subject: [PATCH 3/6] staging: wlan-ng: Fix sparse warnings in hfa384x_usb.c
Date: Thu, 2 Mar 2017 15:19:03 +0530 [thread overview]
Message-ID: <1488448146-29452-3-git-send-email-singhalsimran0@gmail.com> (raw)
In-Reply-To: <1488448146-29452-1-git-send-email-singhalsimran0@gmail.com>
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: expected unsigned int [unsigned] [usertype] datarate
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: expected unsigned int [unsigned] [usertype] antenna
drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: expected unsigned int [unsigned] [usertype] priority
drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: expected unsigned int [unsigned] [usertype] ssi_type
drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: expected signed int [signed] [usertype] [explicitly-signed] ssi_signal
drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: expected signed int [signed] [usertype] [explicitly-signed] ssi_noise
drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: expected unsigned int [unsigned] [usertype] preamble
drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: expected unsigned int [unsigned] [usertype] encoding
drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: got restricted __be32 [usertype] <noident>
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index a7ff572..cdf987b 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3517,14 +3517,14 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
caphdr->hosttime = __cpu_to_be64(jiffies);
caphdr->phytype = htonl(4); /* dss_dot11_b */
caphdr->channel = htonl(hw->sniff_channel);
- caphdr->datarate = htonl(rxdesc->rate);
- caphdr->antenna = htonl(0); /* unknown */
- caphdr->priority = htonl(0); /* unknown */
- caphdr->ssi_type = htonl(3); /* rssi_raw */
- caphdr->ssi_signal = htonl(rxdesc->signal);
- caphdr->ssi_noise = htonl(rxdesc->silence);
- caphdr->preamble = htonl(0); /* unknown */
- caphdr->encoding = htonl(1); /* cck */
+ caphdr->datarate = be32_to_cpu(htonl(rxdesc->rate));
+ caphdr->antenna = be32_to_cpu(htonl(0)); /* unknown */
+ caphdr->priority = be32_to_cpu(htonl(0)); /* unknown */
+ caphdr->ssi_type = be32_to_cpu(htonl(3)); /* rssi_raw */
+ caphdr->ssi_signal = be32_to_cpu(htonl(rxdesc->signal));
+ caphdr->ssi_noise = be32_to_cpu(htonl(rxdesc->silence));
+ caphdr->preamble = be32_to_cpu(htonl(0)); /* unknown */
+ caphdr->encoding = be32_to_cpu(htonl(1)); /* cck */
}
/* Copy the 802.11 header to the skb
--
2.7.4
next prev parent reply other threads:[~2017-03-02 10:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 9:49 [PATCH 1/6] staging: wlan-ng: Fix sparse warning of restricted __le16 simran singhal
2017-03-02 9:48 ` [Outreachy kernel] " Julia Lawall
2017-03-02 9:50 ` Julia Lawall
2017-03-02 11:11 ` SIMRAN SINGHAL
2017-03-02 11:14 ` Julia Lawall
2017-03-02 17:34 ` Alison Schofield
2017-03-02 9:49 ` [PATCH 2/6] staging: wlan-ng: Fix sparse warnings simran singhal
2017-03-02 9:49 ` simran singhal [this message]
2017-03-02 9:49 ` [PATCH 4/6] staging: fbtft: Fix sparse warnings of incorrect type in assignment simran singhal
2017-03-02 9:49 ` [PATCH 5/6] staging: rtl8192u: Fix Sparse warning of cast from restricted __le16 simran singhal
2017-03-02 9:49 ` [PATCH 6/6] staging: rtl8192u: Fix Sparse warning of cast to " simran singhal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488448146-29452-3-git-send-email-singhalsimran0@gmail.com \
--to=singhalsimran0@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=juliana.orod@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sergio.paracuellos@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox