public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: tracing: add #undef to fix compile error
Date: Thu, 02 Mar 2017 09:43:16 -0500	[thread overview]
Message-ID: <1488465796.27824.7.camel@redhat.com> (raw)
In-Reply-To: <20170301221134.6b6873cc@grimm.local.home>

On Wed, 2017-03-01 at 22:11 -0500, Steven Rostedt wrote:
> On Wed, 28 Sep 2016 22:55:54 -0400
> Rik van Riel <riel@redhat.com> wrote:
> 
> > There are several trace include files that define
> > TRACE_INCLUDE_FILE.
> > 
> > Include several of them in the same .c file (as I currently have in
> > some code I am working on), and the compile will blow up with a
> > "warning: "TRACE_INCLUDE_FILE" redefined #define TRACE_INCLUDE_FILE
> > syscalls"
> > 
> > Every other include file in include/trace/events/ avoids that issue
> > by having a #undef TRACE_INCLUDE_FILE before the #define;
> > syscalls.h
> > should have one, too.
> 
> Cleaning out my INBOX, I stumbled over this patch. It looks like I
> missed it. I'm guessing this is still an issue? (Too lazy to actually
> look deeper, well just too tired at the moment).

I believe it is :)

> > Signed-off-by: Rik van Riel <riel@redhat.com>
> > ---
> >  include/trace/events/syscalls.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/trace/events/syscalls.h
> > b/include/trace/events/syscalls.h
> > index 14e49c798135..b35533b94277 100644
> > --- a/include/trace/events/syscalls.h
> > +++ b/include/trace/events/syscalls.h
> > @@ -1,5 +1,6 @@
> >  #undef TRACE_SYSTEM
> >  #define TRACE_SYSTEM raw_syscalls
> > +#undef TRACE_INCLUDE_FILE
> >  #define TRACE_INCLUDE_FILE syscalls
> >  
> >  #if !defined(_TRACE_EVENTS_SYSCALLS_H) ||
> > defined(TRACE_HEADER_MULTI_READ)
> 
> 

      reply	other threads:[~2017-03-02 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29  2:55 tracing: add #undef to fix compile error Rik van Riel
2017-03-02  3:11 ` Steven Rostedt
2017-03-02 14:43   ` Rik van Riel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488465796.27824.7.camel@redhat.com \
    --to=riel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox