linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Todd Brandt <todd.e.brandt@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, todd.e.brandt@intel.com
Subject: Re: [PATCH] ftrace: add ftrace_graph_max_depth kernel parameter
Date: Thu, 02 Mar 2017 17:35:31 -0800	[thread overview]
Message-ID: <1488504931.7212.41.camel@linux.intel.com> (raw)
In-Reply-To: <20170302200950.6d16c91a@gandalf.local.home>

On Thu, 2017-03-02 at 20:09 -0500, Steven Rostedt wrote:
> On Thu, 02 Mar 2017 16:54:57 -0800
> Todd Brandt <todd.e.brandt@linux.intel.com> wrote:
> 
> 
> > BTW I had one other question for you, is it possible to move the ftrace
> > module's initialization further up the queue? ATM it initializes at
> > about 600ms into boot, which is fine since most of the performance
> > issues are happening at 1000ms+. But eventually it might be nice to
> > trace some of the earlier init code.
> 
> module initialization? Or you mean boot up initialization?
oh right, yes. 

> 
> For boot up, we have this:
> 
> 	mm_init();
> 	sched_init();
> 	idr_init_cache();
> 	workqueue_init_early();
> 	rcu_init();
> 	trace_init();
> 
> Now, going before mm_init() will definitely be quite a pain, as we
> that would require making the ring buffer out of early boot memory.
> 
> We could add a early_trace_init() just before sched_init(), with some
> limited tracing. Tracepoints require rcu, although we could make hooks
> to just do hard coded changes (no rcu synchronization) with a flag that
> denotes that trace_init() hasn't been called yet.
> 
> I could toy with the idea, implement it, and see what breaks.
If it was possible that would be great. The reason I ask is because I've
implemented a tool called analyze_boot which I intend to upgrade to use
early callgraph trace (it just uses initcall_debug now):

https://marc.info/?l=linux-pm&m=148667508500967&w=2

I'll have it do the same thing for boot that analyze_suspend does for
suspend/resume: display the callgraphs for each initcall instance in
html. The max_graph_depth param is necessary to keep the html outputs
manageable. Most laptop/desktop machines running standard linux seem to
take at least 5 seconds for boot, but we've got some servers optimized
to boot in less than a second (which means I'd only be able to trace
half of the boot timeline or less). The more coverage I can get the
better.

P.S. I submitted the analyze_boot tool on the pm list but Raphael didn't
think it would fit in the PM tree. Would you be willing to accept this
script? (I can resubmit but nothing's changed since the RESEND).

> 
> -- Steve

  reply	other threads:[~2017-03-03  1:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03  0:12 [PATCH] ftrace: add ftrace_graph_max_depth kernel parameter Todd Brandt
2017-03-03  0:38 ` Steven Rostedt
2017-03-03  0:39   ` Steven Rostedt
2017-03-03  0:54     ` Todd Brandt
2017-03-03  1:09       ` Steven Rostedt
2017-03-03  1:35         ` Todd Brandt [this message]
2017-03-03 14:31           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488504931.7212.41.camel@linux.intel.com \
    --to=todd.e.brandt@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=todd.e.brandt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).